From bdca204371ddc0654ad3cdf9b6ef7d4cc4af275c Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Tue, 7 Jan 2025 12:47:07 -0800 Subject: [PATCH] Fix tests --- .../benchmark/web_bundle_size_test.dart | 2 +- .../goldens/settings_dialog_default.png | Bin 12485 -> 12488 bytes .../goldens/settings_dialog_modified.png | Bin 12725 -> 12726 bytes 3 files changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/devtools_app/benchmark/web_bundle_size_test.dart b/packages/devtools_app/benchmark/web_bundle_size_test.dart index 9f8f12a3fe8..933d9f23a90 100644 --- a/packages/devtools_app/benchmark/web_bundle_size_test.dart +++ b/packages/devtools_app/benchmark/web_bundle_size_test.dart @@ -11,7 +11,7 @@ import 'package:path/path.dart' as path; import 'package:test/test.dart'; // Benchmark size in kB. -const bundleSizeBenchmark = 5200; +const bundleSizeBenchmark = 5400; const gzipBundleSizeBenchmark = 1550; void main() { diff --git a/packages/devtools_app/test/test_infra/goldens/settings_dialog_default.png b/packages/devtools_app/test/test_infra/goldens/settings_dialog_default.png index 85eafe962e8931e1adc37a988b8c9adbebc2d446..e394284c04f7979ea057798494420df87d39a50d 100644 GIT binary patch delta 3008 zcmZWq2~?9;7XB?-=%^sz0B00wH7sqB;nEpTzFhRBm0b)pmc`xzw^qhI;=r-IC1TYZZInEw<*u2S>k2{^a?b3Ei>q zuHdrjxl)_nX}0l5pt`N1@YR#gpR*L35V-E#He<$`z0Z8#bQ`_kxFOg{806sD7@DlK zK#fM9+!(;_lBVv~$$D6P?uZ~R6DJ~<7e{Df_a$b*E%+M~ChN|}Pkz{lAU)rQrLO&V zgw{t~`jr{-qUVx9c!Q0NjlelF>uj-;cb&ajCv3GHD)X% zYy|u1$>#%_EwkpzX*1IG&T`2CV#IX?Ui)Q0GxMs?wU^-?QflJj1P{aGvxJJA0iIte zdrUN>?%-vt{BeN0zEw2Tzm z8F7kco=zWK)K(v_Sy~o`n9OOZ;%ui`vGmzuR(Ck(6M-~I`6ks{v%g3!VcE23(0Tc{ z?w!m3?dK{NGO?AUlp#OMhw~dPu~pNCMD%Gr;Kq+OJCM%T|BuC zLSe@kbz%5e2_`TiE4i=M8XL$DqXoyst)_XQRf+ZURY4YMStH65Y$h>+_G7t(OL>FY zjv%{P-L85Y(Y;r&$`|;KM*F^qOi>wocbjE>#39Y8Oe$G?hUWMC8Cq|x%??YD3~vf# zw0<$yckHEe8)v{*&)lI4PZp!D(&rBWZ?kB8u-{S-<7At8vpVp^T$_5FH-CnN~`pyHc zU+c_NZP$8Q>|gVh2{_V4P_w?>$Ij_WZtb_pq74Vm+VBBu0f)XGz`*Qs_dyrSb|t=^ z97#nZjkTT&ovK-`cBvo72AyU)Ey8~DTL*kSAw!wAre^fSS{&GP(Uev2rlw;0l=kfO zbCH8ZAXYDpOzZH1R8~>rrCEKG7PqQUq_1B<a(<@qSe!ecH^6W9mV02e%mz15C z(;vOgqGomjg?Gx#0C?N(Do@l8*hEkWeM)n4b8h;|OjjwV>~yh4u@Tp&lxB|~vS}ux z0{@Rf+;d(%E)SPWq`i2YDkCQ$;Z%;YEvI~v#z{+6-fUng+T?eoOE>B9qhroM{{tEI zFf+vL;9oi^f}{&yltdQKqiri%FLC6?w|6~2+&wNwAz)T6dB)aH7Q#C^%D^UsL&t7| zIC1?bSJ9P}>Vh#<{pgQ>a~_&B1+8@$~)a||ZT|0w7-_S`C*A>!NMt$nZ-UKMLYOI{@|Gf-^RFKxR^Ba|Fh)-%i0A0G(#?9B(4f7V@YtA(+`~?hX== z0|NB;%fAzSSB-wE^vu?GPfDUsx4oWPoXdLYE1s1V4)SUmtbGz^`P%WXwSCU3)Xs%w zV#tfzLW|T+aLdZ^?HJ0Q2-{eT?E86PPG})h&u4Z-v|UWui|35dM}DvCypY_bnq-AH zXjnl$58x=+*E9PK^bjs4&1@U+CxxIVH`r;&9PhWZ7PiwU@~QEfypD*p=_9wygTE|9 z+w*DmQ&=K_+L_p!XK}F;%nd8AKVA6c@Akw1aNl84M>p$jxB1md1lbW6_}M3+Oj9!= zeK@@l7SM&zt_B0dcN2v3!SjG*0Bz*|@1Xjz`UOaN?mwWBr`=hRhM<2FAl=Hf4+5jI&DddAAJDen4%sAg;7gJ>3Iz8X)4THvWXi(iHg8! z)D1WTd>dQIf{>+)40C9!=X>0Zsd9qQE6f^@$G=qk-X%r61G}A$7*Ca~+OR+%^#PNAq zC~Pllw_i?ZdUJqb89*+X{*6%~EX3rGV4br`Nb)r+id!v!!m;#~^z++BV|)iMK`mJ4ERtM+G5 zcEVBR@(jB9?!VC1cssQaGt2n*aXB#VLvi6rG29kX8RtYE00&nIoiV5;qbBz1Q4G)C<9`CY nkj-!CqeVwHH9k@qSmxeE1O_p953gW1cogUt{8|0ssIUJAfOjnD delta 4023 zcmcgv2~?9;7LKKbR$K?QIErWuVyCjmQa0JF%A^WtQBm1KK_f_j0YNY%KW>8+lxeVr zJydEykwig*gjJCp5-QLX6O70bS)(iofk67+ADpqL#WU@hGw+;)|9`pf-uvBq-*+!{ zzSX{WqE;Xo6J8pxWNyJE65nKfH(MwBp61@H1b>}#CcYm%KXOCceA857hNEY}`w z+SFTWFMP0%ll7{WQy$=OY~1xdI{wCH|4{dJ^uMt)x0!Q$;jqC+6@ej|!`-?H@d6B7S?S9)5%dXs^(Gv8^SGJt_`SJj2dj;%-fTBG z@BbJ)2O4-Oe4iiEq-?LdcWRYG;>iVbs)0K(c%M1eQGhcmDaoL3J1lM%pV8G`-pn(yX8 zhx`ZL>brBwFnhUgDc-f^&GuDO=n%THggc-;3?|k>@rth7uowyR%NZ)xoj$&9hK~$h z^{N+NPFVM)@aQkkC%Jvk+%EF-gmhA?R%hv<0~Q3rB@ zj99}FNDR@C^GYkD0Fkz*jmbpQl$;?S5!ro}k$2mtnix!iuDi+!^_s3KqBuw()%VD! z-751ZMH5LRUCt@sQ-G75-BNj-J&{W2B4Y_5sc3p{Ot-`dKKffo>V@}0WV>XND)l7c90Z6`I8pQX5lNK-jEYe30)Odygm+_BD%e z0=B&DGmF0ST2~~e%t0l`E(fu}U|QUZIw=H0(H+A)o^>{7p<3S$N!NP8C!&EedR?<% zxIQOLpp!PH;WN8kR00y{g!sq?tI=v7KQ7BmF?05-e3X8O{L|_bzF9{Zfx%e_v}&m0 z=^zRcl~);@Pj)-O&rBP3mE2wdgQb_g z1S$Q@omqE%r)2QzOkD@zXe3)O>3bTPdfe1BMCJ(#j_yvv^6W}T+;yfnt~dGEF@o$A zH?qC)L`hITm77SC4w#NT*=-cjz@+Cy>~4<+2uxw zf~B;Oc=C!ErpYEB+*mCU+(O~{9y z-Y?7%KhGdOJxN6KgM&tDqei0XO86}o%~F@ZIoQ-HKo0>9=gi+x_`_VdMsg@qj@ zvSP0M1I<2t+>&)MH^x$`<3H~0rO6i0gr`Tn&?pG)dc=(eCL9Tfis}|6#I2j6#Z0xj zpXAcRxlUB92YcI(@+Nb>f)dQ>ca5918YvxHQ`|$1w}I@bo-vnnU~@jUNXs<@zc!UI z0!(aeJFSqRyR}R9Q^LXu!ljoLmJTg_*LQKHWi_Pe~VvL z#tMJNvne9?oESSNjn=+rH!5NBWf1u-$WxUcT9YOQ6eBBvzpl>Cy=U*A(AZQF)_X}v zmK9lxD@Z)iQ8AZ(1gmXAlG)KpMy3vm6>V+%eWp=gnlAjNcH#c-5dTc1QcanR zJuJH!pOEd0`_5!KSxDH!TRq*KgZh%OkuJ>@^d;#LSBD@XKyi0Amn|v)t|vw)z=lL z+uX%&1`>z7Krel%rQ)J2mWyTAq~}<#kw2h1z-8H-CCC@K#H7n>kj9m;bw8fN^zP9z-Qj+@FvN4x z5f-4f+Fb1dv;T$+@i+W`Fuy(2&0SPX6w++#W2L;vHAuEM((thY5Wa|ex;A`IcpKN* zz;YA4Ea)gte2{#6ACCaYrpr&&E{xZ6JtATvz}1d5`5jQd!BoDS3XU)H!|ia~4-TPA z)!*jo|IafmjGe<}LLOuAZvAhi`vf7XZ_?8{MWM6C-jS${`gY7Pk4&Qvd) z%dL_30Ddek6F2%jBjD-4Cm4+J70+*gzDuRE@vkfLM?kAB?JrRWl)bkW_Kd(zcT`=H z2bj4WHWX>Shl%}~D0oKep+R>llS^^}Qhii2e-k`#={}L{Xi7R zakCrhFCgsz5B_l{y=RmW;C<5&WUjOZIh1K`zo`?@^^LYOV} zB-rd0#JJ`7$fK#Wz;ihugae=fbN%*b5BkF;PMv}s%)l9@h zeN^G!&|=o?h2y%6UdFNx%0S3Agl?|4NJ%y6j+X$DjQL2-=`4 diff --git a/packages/devtools_app/test/test_infra/goldens/settings_dialog_modified.png b/packages/devtools_app/test/test_infra/goldens/settings_dialog_modified.png index 2d48e121803b702ee042b2ca9f2acf4f534045bf..5439001a8accb58cf486fc5a3c43652fe2423e6e 100644 GIT binary patch delta 3221 zcmZuz2~bm47k+4~Rx4C#wJs1XAX+Taf+!(uZZwpL7F;N@v>*{RVGUa(FIFvTG5#hh z5FnvNK|nyn1i}`m6`BG8L>j|mu`CG?Kp+qZNwD`tJM+&!|C@P}mviqq_dDO&E-#oL z{3!EdIBrw)>7+gbEp_U`s^bJf{n;DauU@abDo#E`ctNm_^jn`g(K6is;-QCUaOaiF zr0c$a{r-&1$CEOSDL&igf3C8N)VYP%6dK&QJ?8U68+H(Ut-90Zf3G@D!t^E|0QQR!`a zdivfe4KGhQo($hgh&K8&E*xhTZJ5sCDcqx;_0_~(99sBBE(dR1OiL@gc(fS^z9Vt+7zpx&vcZ@M{FWDUMH67I=Y z_aC#ASC|oH-g1*$4#}RaOTErFacLu#((x5rA@oTM`j!HIvV{-*U6@v6KduuMIi;*> z44L?)qf91R^ZvTG+dQtl4?!;**_M4fACL8RgpM!VI;DO#yK<*~dFJ-OWeB3rJ&}oS zY3l=BIFyWl<8TlF1We0sp9E{VM6Eitz)Zj0X3J*F_w-*7*i{t&vT3m1#nmhO+EC7fc35g{YfB5yUZevK`aX@qX3*JuB}1cE|<pFOjvn8N7~`#xZ4XSsLhdDtoKjbZRGr-eQa{IZdsb8J@ ztCKQi84j=15VsQw+CcWq{!V7X}m7u)GDOqd_P*r1CA8lR-lReN-1&!5c zr<)RHJ0)07I8qbF7CTPp?BU7!vZz0{Cdc6V!sm$9^4H~RS`}A!w^932Y}BP3SLuFx zQ%*s?wkLPr&T@3`Qkrb)X;T?Tr<9yGN;wqgOkhprqeKp+KpP< zQyUnMe6y=2Qz#sm@I1@TOpuMdUVurypD(x}e=pA_u{sNdcle~}XG2Xb&xp)Gr2su=c1FSjeGX#QWnj3Cps2ujKpnXEjq9oco3-htd zAgFCA!x&fswGb*7w~wyyv~l(ZUPtaIMTJn(z@#8Ls#m~;htI_JR_EA8%iK&_I2WE@ z+h8*OP-}z3IhvUvE)f%xPvzV20rB4}(rQAPnNNlZ6xUy>fV1w{vJ4+IfIK|{tlXsnZ95Ys?8tt_f4F9$h zykD+`{Xz66Jqyr`e*3T@*L()&`YZ?k8hRBa!ro48v42&=tk$Zen)!v_VpX9!KsG{I zBy)G63U%>%CXCx=Mmnn4TzgVi1qYU;uXfOkMPoUE)$x&D${FmN>7f(Ern@cv{+D!q zf~bR_*&H<)FwxyjE*(;%M2&IL@_hSj&tnx}wt@=!5cV!us+U!hVq)x&a^cG8u-R!g5@OZnIeC zUQV+yjpxV}e^+)VD*70jbKOaE{(@IODjhk%-{H7-K?AzknQK=;5G!TPT6oWWED+eJ z*tw#~$%sbfa?FK@z!opAbIpLXT)upVSBIVdkhF9F{;D#X*r=o;_N>Z^LnU(JhpSJ^ znlE8FbF@bLo9Zq#O@o{9GgZDWLF8ygcA`BjXbCo~{a3B%bSeesVrO@|tQA`rE|a%7 zV&{4_EeyFZ4%;UTQOdZheK=%o(D;6Txm5bh1v{5W19_vQaXyLY**HYFQ9$a}l>NZ0uVRL8E*KVzeA(5Z#gPNZbo}-^58O#;!E3 z0~P%Z!Uw_%?8^VH#nC^TQim9hC*+G7iR_`RSF5px&ncJydVvTOd%=K>A&>O~5c}EVNEfHFkC`Q~-AC=6`*g+ijM$vl!w05e4JT{6k#%5U*HbvKx1sdvgpIq`1rZ z(y|Y};3rX7JIRCf{T4!}<4;3Jo`VUs#s`1E&4=Y?dd2hK`kKtuka5cWMH%*#Z)0mp z%M}!=>Pb3I;1HzvDVHE7T5}|`l~>%wV~MLlDJ*V(+s0x#Ph%7n3Y2}IwA_73_FB*Yp1&tQ2$G>8?wsw9lv zS7HcGx#Wprz0M<1J(v{ywi84!rVV(OqI^OJ&ff&wTb8Ax{V)4uhn<&&uYVRmx$Nax z^rG~Dhz|4Nr6k0Z6|$eX0p%g6E@hiTX&AfZEe}%E_JV7NoeN=FFuEBAw9%dO027d| z9(AD2y^F6q%WU2n|d}kEFd4HNQ*(K7~W4ptUagWnKyli1~5ebKz65m<<3oo zmjFMn?eo$8`KTl}jN=vM!{q6YS(30_baW*Oj;oK1R}GJ+4!0EC$ASYrq4I6M{pf9S zI8aY(WHt$L@rWWa!}Q9T(mR7UGji39qgw#YnlfXcld_c1(ajpXXC4PzNd2=wuo^Bp z;TN}xK0r^gan>hG1MpVdA)h zrRCSHT+XmV-6`8aj-1Fr^V=BMjb=5&3So|k(|b_eUcRHKm3iLdaef%PsPkfJJ$J=N v^L?sUbU;1i+V)1GTk%P0z2$rB>Ayhg*b1u{8}5Fv0^tuHK2W?b=*NEmF5|C9 delta 3216 zcmZWrd011|62DYIpH|UAr78g`k-#Uspiq`1EN;cP02UMxAt*{fOejKFM7Y#GrL`3_ z*NQ+$P%0{*fM_CXs8*1&1dR|OK(N7pgs_Fhm=NB%f!BZD{l0uR_netCGr#%G%;APT z2`gh6!?PPK1Cls;8rSfYz|N(th>D2 zH}GtbebI)WFF(e9x5szMt!H~8FTB3W)mxwLZ}+AC()blOFGO9mrq_p9#yl_yQ%^0) zx_sgIrO}Tb)k-y4dty%FDquO7H%Pt4nk`O?;}0?Aa8WF_DWHyTLs4l9u}y*eZFnAq zasJXw_O&h1Nt-0e{aJyIutd|}jcnu2kCX&^u=i<)=T_PVP|94u?`c6)s;b#}K$gpY z71MBMUsiZ;6~iw+RW;dMarXV?j6prfIw3{qSX{Idg6i|jjaEX?cm_wK<{mpM^ie9{ z;tW9mp6HZr?#LA6mD`7@1#PvN^j7m!#oewC%fE)u=UnKw4Dib5>&(-Sa)PVH$0l;q z!?k)96|(Xe{dEgsdw z4G`&nASkpR!~GsRuQ9oM3LM*27ZxCrr&ATkDcrBJvWu2(P0LW>`cU5!!1UR-&(>}> z)@ko`T{s;1&1{WDRM8S3vzU>hSRgPa|5O-x_)t19y*&(v_^$Pao&6W=_R|bC@*gX; z0{T$I%%4UXf`ZHkV-fLPu2gDk%4~uokuWA*FPV9k-gf266)Q5Aj+q}9ndW6pOwcgF z{M?d34$n3qH73ccqPIsZ*T(Jk_E7j?TKlG+QGFArk8PvV(}8`8xO#8V7`o-N_31YfEWO_r!Ve zsJAe#FJ_FVnw!bZotu^LrK;3w4?j1U-#ROv8{v^;xP;Vpb~JCyL|bYX)L0QCEj%M} zpLodk7!*=(oVwi^D{$lB*qThkyp3jTJt z#E<*%x+I84|Emp8NliNZ@Yt(~^ZZ`UeKubrQ!7$ug3Oc%(IY~@6VI-UPM&y?H7Vlt zU0Z(uL44fH39D0nrx7_pwV$dZ#ZFnr&L3Y*8cz%H0zs{?M(F`TZqpBf#$Kuh^N@l} z!fnEel<;@Y^aG!Mzul{X%7Rl*JCUa2>KNi-&8v=pDbhv=Dw}20Q2=)U#j?0(Fg`-Z z6}I~?1LaK)IaWd3i~uiy?m1615C|H|zOvETb;nO+#$PtLaH&IXQ5aZt>v#DY-OZK&yHKw6mf1t=v5YIk1OV&1&|E?iUqckTXVb<@k2b(mJOL}V?J$R3 z1wkX(@K)3WloHm&e12BJDH&>t;v|edV%N~|EVyrgs_3Wx-3eUwv#`N{WLRHcksU1gBW1&yWTSmkX(1M!ocA=0cw z!F%hVt8Vl}$k!WDZ?s#aBLvmZPMp{z=GL}PXi5Sd5G*mi=G8<_WvtiaaB=AYRa8sv z>_khp!(C|-D7VzRs5cNab!C~khId}8G+~h7o|r}}vKg%TIYV?Tw)IfuL<65SDS9f+ z5XW`~QsYU6AP-}vxTUBfcsyM2sQW_#`}2hpzT8LqWz0A;+Y+z zHA*5zU}$JK>j-cHIwx-)TxezJ7aGUHV=eLroJrgMhN~#TiVh8edU&GlG}Zbs2UtFw zK+MI+6Zn+EhtWCVhwvzKYO?YWj)e>2Yrg59R0~Dp zW9Khh%s{to0 z(Xj#e;Dbr**Q=BbZ+Ub|p6EpH@yDdw+@m2Y@tR;_89>Bwk#r+pDjUE3Z4FR)Td;l+ zcT^vVu?PoorXXw!*TuKpBDKJFbk*byocrsl@+IL^`7fmjwRBnguQlbdvmrqVZ*kvF zas;)V(^buFleP6?W{*7M<3JCoR@L!Pgdq`FlwYGIQSvro zq^-xflTjl1zg-kYx(Ns^zz}>%VFhO6T0iox?fyuqg*9+0Xz%}+k|^vIu{GB^TXS43 ziG6Q-r>laiyGJT~Dny;D1l>4_OTs~s{D!IH>*)=E!@~y`2F#EV&dxQT0NCWY9vR!X z3rR8G2K!1?!yv+XGgTeHQy(Qu{w4DldQd+6|0`}mD6I^xp^fnkI&jmp@719Ej3fS; zui;D)v!$dB7^!J)!#+PC94T21K7MTQ28r^`kIZpqp1Ics2w&5PtgwaP#Thf)qdPj$ zP$C4Tf6^IHZAb4U{ch)dmO*Ko4xk@j`P0NsWG7tUkvveNdzhrGf&9YA?qLg1AwTJu zxV!Juam`qLi*8-x8Ww$}HLU$cKSWY2Rw5sl>6>sAD@o^s4S|arv7A%0y;Ihbve~dvG`u zSUHEz@-+8$uHqKi37hSQdTG$Ii&>CUn8YQ3vp**g!JP9nkI0cx$#wpDFlxFz%NT{- z<1IR*KJ5{6CHp5Y4x56QEa;IrvPZ*!ul2dQ)MP%U5gnR*n5@I-(S?<2CJT7A5%ns~ z8NFe7aw5g?j!jF*H~gudF-@IJrtjNUtW(}fWNK1{j&KkLh|}4gPBKcAgkn!YnT^kUS=_qy`$3ehtXu$Qx9VpuFSpz*- z>S1sjPCF5W^dJMtAf2}fpMwf?LubWJgKqBJ5hi8d*$}1?)0VuAM*vND%JpS2nN6M? z4|?&Nx$^<#QHC{O+`O0W+H;>v8^i@_IypN{-IfA7T!$tBa%S(N`;j?z9Y2)+!CAgW ud)LjyLJ#n2&D1=@V~2kEAGoC^X}2KvFL*|w91IKWK;+%tyB_Wcz3^XzUW(NK