Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webview_flutter_tizen] Add tizenEnginePolicy extension api temporary #670

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

JSUYA
Copy link
Member

@JSUYA JSUYA commented Feb 16, 2024

There was a case where the ewk engine failed to load on some devices using Tizen 6.0.
As a result, ewk init failed and an engine instance could not be created. We have not found an exact cause for this.
Calling ewk_set_version_policy(1) will solve the problem,
but using UWE(upgrade web engine) in 3rd party application is not recommended.
(The webview works may not be guaranteed to normally.)
Therefore, add a temporary API and have user application call it.
This API may be deleted in the future depending on whether tizen version 6.0 is supported.

related issue: #647

@JSUYA JSUYA requested review from bbrto21 and swift-kim February 16, 2024 08:18
@JSUYA JSUYA marked this pull request as draft February 16, 2024 08:19
@JSUYA JSUYA force-pushed the webview/ewk_set_policy branch from 5459f78 to 0e5306b Compare February 19, 2024 09:14
@JSUYA JSUYA changed the title [webview_flutter_tizen] Add setEnginePolicy api temporary [webview_flutter_tizen] Add tizenEnginePolicy extension api temporary Feb 19, 2024
@JSUYA JSUYA force-pushed the webview/ewk_set_policy branch from 0e5306b to 5d2934f Compare February 19, 2024 09:18
@JSUYA JSUYA force-pushed the webview/ewk_set_policy branch from 5d2934f to 7cbc741 Compare March 12, 2024 08:10
@JSUYA JSUYA marked this pull request as ready for review March 12, 2024 08:10
@JSUYA JSUYA requested a review from xiaowei-guan March 12, 2024 08:17
There was a case where the ewk engine failed to load on some devices using Tizen 6.0.
As a result, ewk init failed and an engine instance could not be created.
We have not found an exact cause for this.
Calling ewk_set_version_policy(1) will solve the problem,
but using UWE(upgrade web engine) in 3rd party application is not recommended.
(The webview works may not be guaranteed to normally.)
Therefore, add a temporary API and have user application call it.
This API may be deleted in the future depending on whether tizen version 6.0 is supported.

related issue: flutter-tizen#647
@JSUYA JSUYA force-pushed the webview/ewk_set_policy branch from 7cbc741 to 3cf8bc5 Compare March 28, 2024 04:43
Copy link
Contributor

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@JSUYA JSUYA merged commit 686591d into flutter-tizen:master Mar 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants