Enhanced FocusVisual for various controls #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batzen
reviewed
Mar 8, 2023
| @@ -58,7 +58,7 @@ | |||
| TargetType="{x:Type Fluent:Button}"> | |||
| <Setter Property="Fluent:RibbonProperties.IconSize" Value="Small" /> | |||
| <Setter Property="Fluent:RibbonProperties.MouseOverBackground" Value="{DynamicResource Fluent.Ribbon.Brushes.BackstageTabItem.MouseOver.Background}" /> | |||
| <Setter Property="FocusVisualStyle" Value="{DynamicResource Fluent.Ribbon.Styles.ControlStyleEmptyFocus}" /> | |||
| <Setter Property="FocusVisualStyle" Value="{StaticResource Fluent.Ribbon.Styles.FocusVisual.Tight}" /> | |||
There was a problem hiding this comment.
All resource usages have to use DynamicResource.
Otherwise people won't be able to overwrite those.
|
Just had a look at this.
I guess it would look way better if it had a narrower dotted border, instead of a rectangle with a 2 px stroke. |
…ator than the standard striped one. This is also to conform to the requirements in WCAG SC 1.4.11.
…han the current dimmed theme color. This is to conform to the requirements in WCAG SC 1.4.11.
…ritten by the consumers.
…, by only marking the ActiveBorder instead of using a FocusVisualStyle.
…remove the now superflous .Tight version.
|
I tried to base the solution off of the newest version of Office (2021). There every control has a 2px solid border when focused, even including textboxes and comboboxes. Should I continue with the solid line, or use the striped one? From Word 2021 f.ex.: Combobox: Spinner: Button: Backstage: |
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#792
Improved the visual cue for textboxes when getting keyboard focus by using the full theme color.
Improved the FocusVisualStyle for the other controls to follow the WCAG recommendations.
https://www.w3.org/WAI/WCAG21/Understanding/non-text-contrast.html
If this is to be improved further, the next step would be to make the controls taller in general, or add more spacing between the elements in the ribbon. As it is right now the textbox, f.ex. cant increase the size of its border without pushing nearby controls 😅