out_rdkafka2: Handle some of the exceptions as unrecoverable errors #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmo0920
force-pushed
the
some-of-errors-handled-as-unrecoverable-errors
branch
from
d23d2e9 to
de38e7d
Compare
This is because msg_size_too_large and topic_authorization_failed error codes should be treated as an unrecoverable error. In Fluentd, we need to mark as unrecoverable with raise Fluent::Unrecoverable. But current implementation does not handle them as unrecoverable errors. Signed-off-by: Hiroshi Hatake <[email protected]>
Signed-off-by: Hiroshi Hatake <[email protected]>
cosmo0920
force-pushed
the
some-of-errors-handled-as-unrecoverable-errors
branch
from
de38e7d to
ce0274b
Compare
ashie
reviewed
Jun 25, 2024
|
FYI: we use flog to generate arbitrary length of logs. In this case, we use |
daipom
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Thanks for this fix!
I have confirmed that this feature works as intended.
Sample config:
<source>
@type tcp
tag test
<parse>
@type none
</parse>
</source>
<match test.**>
@type rdkafka2
brokers localhost:9092
topic fluentd-test
<format>
@type json
</format>
<inject>
time_key time
</inject>
<buffer []>
flush_mode immediate
chunk_limit_size 100M
</buffer>
</match>Send 10M characters:
$ echo $(base64 -w0 /dev/urandom | head -c 10000000) | nc localhost 5170
Then, msg_size_too_large error occurs, and it is handled as an unrecoverable error.
2024-07-10 18:58:53 +0900 [warn]: #0 Send exception occurred: Rejected due to Broker: Message size too large (msg_size_too_large) at /home/daipom/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/fluent-plugin-kafka-0.19.2/lib/fluent/plugin/out_rdkafka2.rb:529:in `rescue in block in enqueue_with_retry'
2024-07-10 18:58:53 +0900 [warn]: #0 got unrecoverable error in primary and no secondary error_class=Fluent::UnrecoverableError error="Rejected due to Broker: Message size too large (msg_size_too_large)"
2024-07-10 18:58:53 +0900 [warn]: #0 /home/daipom/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/fluent-plugin-kafka-0.19.2/lib/fluent/plugin/out_rdkafka2.rb:529:in `rescue in block in enqueue_with_retry'
2024-07-10 18:58:53 +0900 [warn]: #0 /home/daipom/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/fluent-plugin-kafka-0.19.2/lib/fluent/plugin/out_rdkafka2.rb:484:in `block in enqueue_with_retry'
2024-07-10 18:58:53 +0900 [warn]: #0 /home/daipom/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/fluent-plugin-kafka-0.19.2/lib/fluent/plugin/out_rdkafka2.rb:483:in `loop'
2024-07-10 18:58:53 +0900 [warn]: #0 /home/daipom/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/fluent-plugin-kafka-0.19.2/lib/fluent/plugin/out_rdkafka2.rb:483:in `enqueue_with_retry'
2024-07-10 18:58:53 +0900 [warn]: #0 /home/daipom/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/fluent-plugin-kafka-0.19.2/lib/fluent/plugin/out_rdkafka2.rb:454:in `block in write'
2024-07-10 18:58:53 +0900 [warn]: #0 /home/daipom/work/fluentd/fluentd/lib/fluent/event.rb:319:in `each'
2024-07-10 18:58:53 +0900 [warn]: #0 /home/daipom/work/fluentd/fluentd/lib/fluent/event.rb:319:in `block in each'
2024-07-10 18:58:53 +0900 [warn]: #0 /home/daipom/work/fluentd/fluentd/lib/fluent/plugin/buffer/memory_chunk.rb:81:in `open'
2024-07-10 18:58:53 +0900 [warn]: #0 /home/daipom/work/fluentd/fluentd/lib/fluent/plugin/buffer/memory_chunk.rb:81:in `open'
2024-07-10 18:58:53 +0900 [warn]: #0 /home/daipom/work/fluentd/fluentd/lib/fluent/event.rb:318:in `each'
2024-07-10 18:58:53 +0900 [warn]: #0 /home/daipom/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/fluent-plugin-kafka-0.19.2/lib/fluent/plugin/out_rdkafka2.rb:424:in `write'
2024-07-10 18:58:53 +0900 [warn]: #0 /home/daipom/work/fluentd/fluentd/lib/fluent/plugin/output.rb:1225:in `try_flush'
2024-07-10 18:58:53 +0900 [warn]: #0 /home/daipom/work/fluentd/fluentd/lib/fluent/plugin/output.rb:1538:in `flush_thread_run'
2024-07-10 18:58:53 +0900 [warn]: #0 /home/daipom/work/fluentd/fluentd/lib/fluent/plugin/output.rb:510:in `block (2 levels) in start'
2024-07-10 18:58:53 +0900 [warn]: #0 /home/daipom/work/fluentd/fluentd/lib/fluent/plugin_helper/thread.rb:78:in `block in thread_create'
2024-07-10 18:58:53 +0900 [warn]: #0 bad chunk is moved to /tmp/fluent/backup/worker0/object_dc0/61ce1b1a61ef66b93c0d58386e983d46.log
ashie
approved these changes
Jul 10, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because msg_size_too_large and topic_authorization_failed error codes should be treated as an unrecoverable error. In Fluentd, we need to mark as unrecoverable with raise Fluent::Unrecoverable. But current implementation does not handle them as unrecoverable errors.