diff --git a/air/src/execution_step/instructions/embed.rs b/air/src/execution_step/instructions/embed.rs index 4eeff315d..d08ab36c5 100644 --- a/air/src/execution_step/instructions/embed.rs +++ b/air/src/execution_step/instructions/embed.rs @@ -84,6 +84,7 @@ fn classify_starlark_error(err: air_interpreter_starlark::ExecutionError) -> Exe use air_interpreter_starlark::ExecutionError::*; match err { + // TODO perhaps, Other should be uncatchable Value(_) | Function(_) | Other(_) => ExecutionError::Catchable(CatchableError::StalarkError(err).into()), Scope(_) | Lexer(_) | Internal(_) => ExecutionError::Uncatchable(UncatchableError::StalarkError(err).into()), } diff --git a/crates/air-lib/interpreter-starlark/src/lib.rs b/crates/air-lib/interpreter-starlark/src/lib.rs index de8b6c001..deab9fbe1 100644 --- a/crates/air-lib/interpreter-starlark/src/lib.rs +++ b/crates/air-lib/interpreter-starlark/src/lib.rs @@ -82,6 +82,8 @@ pub fn execute( // 2. AstModule is consumed on evaluation // // for that reason, we have to parse the script on each invocation + // + // see https://github.com/facebook/starlark-rust/issues/124 let ast: AstModule = AstModule::parse("dummy.star", content.to_owned(), &Dialect::Standard) .map_err(ExecutionError::from_parser_error)?;