Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FluidBufNMF argument resynthMode is redundant #128

Open
tedmoore opened this issue Jul 13, 2022 · 1 comment
Open

FluidBufNMF argument resynthMode is redundant #128

tedmoore opened this issue Jul 13, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@tedmoore
Copy link
Member

FluidBufNMF's argument resynthMode is currently used to specify whether or not the object should perform resynthesis after decomposition and write it into the buffer specified by resynth. Because a buffer needs to be specified by resynth, this is enough to indicate to the object that resynthesis should occur, therefore resynthMode is redundant.

I propose that we remove the resynthMode argument from the class definition in SuperCollider. The class definition can simply check if resynth is a buffer or nil, and if it is a buffer pass "resynthMode = 1" to the client.

I understand that this will break parity with the other CCEs and I still think it makes sense to do. I'm happy to implement if agreement is reached.

@tedmoore tedmoore added the enhancement New feature or request label Jul 13, 2022
@tedmoore
Copy link
Member Author

tedmoore commented Aug 9, 2022

@tremblap pointed out that this would mean the docs would need a way to render the resynthMode argument for Max and Pd but not in SuperCollider. I'm kind of poking at this now, but thought I would also alert @weefuzzy to this idea just in case I'm going to hit a wall he can already envision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants