Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test passing to operatingModelRun only from year before projection #70

Open
iagomosqueira opened this issue Apr 2, 2023 · 1 comment
Assignees
Labels

Comments

@iagomosqueira
Copy link
Member

To minimise the amount of memory used by operatingModelRun, rfishery and biolscpp could be windowed to start on the year before the first one of projection in control.

A speed and memory test would be useful.

@iagomosqueira iagomosqueira self-assigned this Apr 2, 2023
@iagomosqueira
Copy link
Member Author

Memory usage decrease, on a single test with ple4, from 41 Mb to 36 Mb, 13%, by sending to Cpp only from the first year of projection minus 1. But the crude subsetting implemented is slow, so execution time goes up, from 330 ms to 550 ms.

new <- microbenchmark(
hinf <- fwd(ple4, sr=rec(ple4)[, ac(1980:2017)],
  control=fwdControl(year=1980:2017, value=fbar(ple4)[, ac(1980:2017)],
  quant="fbar")), times=20L)

More efficient subsetting on FLFishery and FLBiol could make a difference here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant