Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out registry specific nested modules #26

Open
joelwass opened this issue Mar 5, 2021 · 0 comments
Open

Filter out registry specific nested modules #26

joelwass opened this issue Mar 5, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@joelwass
Copy link
Member

joelwass commented Mar 5, 2021

Currently we just search for package manifests within the root of each repository. If we search recursively the entire project using https://docs.github.com/en/github/searching-for-information-on-github/searching-code then, if someone accidentally pushes node_modules (or other language equivalent), our distribute org donation could take exponentially longer than expected (resulting in an error).

We need to filter out all search results when searching for package manifests than include "node_modules" or the "node_modules" language equivalent. This would enable us to distribute donations to all repo deps we find, no matter how nested.

example branch here: https://github.com/flossbank/distribute-org-donations/tree/path2

@joelwass joelwass added the enhancement New feature or request label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant