New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lodash #111

Open

styfle opened this issue Sep 20, 2018 · 1 comment

styfle commented Sep 20, 2018 •

edited

Loading

It looks like the only usage of lodash is in Match.ts so you're bringing in over a MB of lodash code to do something that takes a couple lines of js.

return x &&
    typeof (x[Consts.IMATCH_MATCHES_NAME]) !== 'undefined' &&
    typeof (x[Consts.IMATCH_ID_NAME]) !== 'undefined' &&
    x[Consts.IMATCH_ID_NAME] === Consts.IMATCH_ID_VALUE;

rakeshvanga commented Jul 27, 2020

I would also like to add that lodash has security vulnerabilities. Can you remove it or update your dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment