Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numCollision recording grey-out #52

Open
lingcy0328 opened this issue Sep 20, 2021 · 2 comments
Open

numCollision recording grey-out #52

lingcy0328 opened this issue Sep 20, 2021 · 2 comments

Comments

@lingcy0328
Copy link

Hi, i'm confusing on why the numCollision statistic recording is commented out. Did it means that the collision is not considered anymore in the LoRaMac.cc ?Or did it moved to other .cc file?

@mariuszslabicki
Copy link
Collaborator

Hi

If I remember correct I have commented it out as I have not verified if number of collisions has been counted accurately.

@lingcy0328
Copy link
Author

Hi, I found another numCollisions statistic recording in LoRaReceiver.cc, that is for physical layer. Perhaps you replace the one in LoRaMac.cc with that? Also, I found that the numCollision in LoRaMac.cc is not used throughout the .cc file but only initialized in the initialization().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants