-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: deprecate this.$node #302
Comments
+1 |
Not depending on jQuery would be great. +1 |
+1 |
+1 |
@BugiDev no. You already have |
What about |
@nkzawa it'll return a |
@giuseppeg Yeah, but that will break backward compatibility. We need a new method for that. |
@nkzawa it should be fairly easy to use function withJQuery() {
// define this.$node
this.after('initialize', function () {
this.$node = $(this.node);
});
// wrapper for select to return jQuery objects
this.around('select', function (select) {
return $(select([].slice.call(arguments, -1)));
});
} That you can manually mix with a component: // Must be the first mixin
var MyComponent = flight.component(withJQuery, function () {}); Or we could decide to hook into the registry and do that automatically for you. |
@giuseppeg It sounds great! |
+1 |
This is closely related to #320, and will probably be fixed by that. |
@PhUU you can close this I guess |
Yep! Woohoo. |
If there's still interest in eventually not depending on jQuery, this might be worth deprecating now as it seems to be the only place where we expose a jQuery wrapped object from the Flight API itself.
The text was updated successfully, but these errors were encountered: