Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using custom components will vibrate #316

Closed
no-chili opened this issue Apr 8, 2024 · 5 comments · Fixed by #320
Closed

Using custom components will vibrate #316

no-chili opened this issue Apr 8, 2024 · 5 comments · Fixed by #320
Assignees

Comments

@no-chili
Copy link

no-chili commented Apr 8, 2024

There may be some bad things about this
I am using a custom picture component, which will vibrate

2024-04-07.19.06.39.mov

Originally posted by @no-chili in #315 (comment)

@Amir-P
Copy link
Member

Amir-P commented Apr 10, 2024

Sorry for the delay. It's reproducible. Looks like it's happening only when the embed is bigger than viewport.

@Amir-P
Copy link
Member

Amir-P commented Apr 11, 2024

Hi @no-chili, Could you please test if #320 fixes your problem?

  fleather:
    git:
      url: https://github.com/fleather-editor/fleather
      ref: fix/scroll_to_reveal_cursor_bigger_than_viewport
      path: packages/fleather

@no-chili
Copy link
Author

Hi @no-chili, Could you please test if #320 fixes your problem?嗨,您能测试一下是否 #320 解决了您的问题吗?

  fleather:
    git:
      url: https://github.com/fleather-editor/fleather
      ref: fix/scroll_to_reveal_cursor_bigger_than_viewport
      path: packages/fleather

It is now working fine on both the simulator and the actual device. Thank you for your fix.

@no-chili
Copy link
Author

no-chili commented Apr 12, 2024

I'm sorry, I accidentally clicked on close. This should have been waited for your review.

@no-chili no-chili reopened this Apr 12, 2024
@Amir-P
Copy link
Member

Amir-P commented Apr 12, 2024

No problem. Thanks for testing it. We will add the tests and merge it then. @no-chili

@amantoux amantoux removed the bug Something isn't working label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants