Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do links on homepage are not valid anymore #386

Closed
rousik opened this issue Apr 30, 2020 · 3 comments · Fixed by #387
Closed

What to do links on homepage are not valid anymore #386

rousik opened this issue Apr 30, 2020 · 3 comments · Fixed by #387
Assignees
Labels
enhancement New feature or request

Comments

@rousik
Copy link
Collaborator

rousik commented Apr 30, 2020

http://scrgrb.in/cr9 - do/dont links are not valid for English anymore after act_and_prepare has been restructured.

Note that these links are valid for languages that have not been translated yet.

Ideally, the entire blue caption would be clickable and would bring people to Act and prepare section.

I have checked analytics and majority of people do not go beyond the homepage and I wonder whether making this more clickable might help with that (related to issue #325).

@rousik rousik added the enhancement New feature or request label Apr 30, 2020
@rousik rousik changed the title What to do What to do links on homepage are not valid anymore Apr 30, 2020
@emersonthis
Copy link
Collaborator

Looks like the link still works but it has a fragment that no longer exists (#do / #dont). We should probably tweak the language a bit too since we're no longer doing such a strict DO / DON'T format.

@rousik
Copy link
Collaborator Author

rousik commented May 1, 2020

Right, it's not outright broken but it makes no sense. I will try to think about how to update the language for this.

@rousik rousik self-assigned this May 1, 2020
@rousik
Copy link
Collaborator Author

rousik commented May 1, 2020

well, nevermind, I saw your PR a bit too late :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants