Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relay should wait for finalization before considering op included #13

Open
nicolasochem opened this issue Apr 12, 2022 · 0 comments
Open
Assignees

Comments

@nicolasochem
Copy link
Contributor

We currently discard a pending operation when we see it in a block.

But, there may be reorgs. The relay should keep sending it until we see a block at level N+2 and block at level N has the transaction included.

Tenderbake has 2 level finality, so existence of a N+2 block implies that the block N is final.

There is no impact on privacy: when we see a block at level N, others can see it.

There are 2 ways to implement: either ingest every block and tag them internally as pending/final/uncle(you need to watch for parent-child relationship), or query the block at level N-2 whever you see a block level N.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants