Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primiry sub tag != secondary tags #4065

Open
Demandss opened this issue Oct 10, 2024 · 0 comments
Open

Primiry sub tag != secondary tags #4065

Demandss opened this issue Oct 10, 2024 · 0 comments
Labels

Comments

@Demandss
Copy link

Current Behavior

If I want people to create discussions using at minimum one primary tag and at minimum one primary subtag, it doesn't work properly because the primary subtag doesn't equal the secondary tag.

It gives an error about lack of permission.

Steps to Reproduce

  1. Create a primary tag and put a primary subtag in it
  2. In the settings specify minimum primary tags 1 and minimum secondary tags 1
  3. Try to create a discussion by specifying one primary tag and a primary subtag
  4. It will give a permissions error

Expected Behavior

When you create a discussion using at minimum one primary tag and one primary sub tag the discussion should create and not give permission errors

Screenshots

No response

Environment

  • Flarum version: 1.8.7
  • Webserver: nginx/1.18
  • Hosting environment: vps
  • PHP version: 8.3.8
  • Browser: Firefox 131

Output of php flarum info

No response

Possible Solution

After reviewing the open-source code of the tag extension, I concluded that the check for whether a tag is secondary is done through "tags.position == null".
However, primary subtags have a position, and to fix this, we need to use the following check: "tags.position == null || tags.parent_id != null".
This way, primary subtags will also be considered as secondary tags, as they currently should be.
I also believe we need to check if "tags.parent_id != null" and if the parent of this tag is included in the selected tags.

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant