Feat/lag histogram #1203
Draft
Feat/lag histogram #1203
+103
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moshloop
reviewed
Dec 1, 2024
| return err | ||
| } | ||
|
|
||
| // For now, measure a single lag for the entire batch instead of per config item |
There was a problem hiding this comment.
It needs to be per per config item, at the tail end is what is going to hurt us -
moshloop
reviewed
Dec 1, 2024
moshloop
reviewed
Dec 1, 2024
| @@ -89,7 +98,8 @@ func (t *SharedInformerManager) Register(ctx api.ScrapeContext, watchResource v1 | |||
| if ctx.Properties().On(false, "scraper.log.items") { | |||
| ctx.Logger.V(3).Infof("updated: %s %s %s", u.GetUID(), u.GetKind(), u.GetName()) | |||
| } | |||
| queue.Enqueue(u) | |||
|
|
|||
| queue.Enqueue(NewObjectQueueItem(u)) | |||
There was a problem hiding this comment.
We need update lag - this is actually the most critical one - I have added an is-healthy LastUpdated func https://github.com/flanksource/is-healthy/pull/144/files#diff-b7f1feaa038882966a9d30e0b96e476dccccc2608dd8a660f80767dbbc635b6fR183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #1194