fix: ignore webhook checks when using delete transformation strategy #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityathebe
commented
Nov 7, 2023
| // Get transformed checks before and after, and then delete the olds ones that are not in new set. | ||
| // NOTE: Webhook checks, although they are transformed, are handled entirely by the webhook caller | ||
| // and should not be deleted manually in here. | ||
| existingTransformedChecks, err := db.GetTransformedCheckIDs(ctx.Context, canaryID, checks.WebhookCheckType) |
There was a problem hiding this comment.
I think this should suffice
moshloop
reviewed
Nov 7, 2023
adityathebe
force-pushed
the
fix/webhook-checks
branch
from
f87d4ba to
773f008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #1423