Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only subset of <g7:enumset-ROLE> supported #4754

Open
Jefferson49 opened this issue Feb 11, 2023 · 4 comments
Open

Only subset of <g7:enumset-ROLE> supported #4754

Jefferson49 opened this issue Feb 11, 2023 · 4 comments

Comments

@Jefferson49
Copy link
Contributor

Oberserved with webtrees 2.1.16

If using ROLEs in Gedcom 7, webtrees currently only offers a subset of the defined roles in Gedcom 7.

The GEDCOM 7.0.11 specification contains more roles:
< g7:enumset-ROLE >
CHIL, CLERGY, FATH, FRIEND, GODP, HUSB, MOTH, MULTIPLE, NGHBR, OFFICIATOR, PARENT, SPOU, WIFE, WITN, OTHER

Screenshot:
webtrees enum ROLE

@fisharebest
Copy link
Owner

The code is using the GEDCOM 5.5.1 definition of ROLE_IN_EVENT, not the GEDCOM 7.0 defintion.

@Jefferson49
Copy link
Contributor Author

Oh, yes of course. Thanks for the explaination. I forgot for a second that webtrees is logically still working in Gedcom 5.5.1, even if I import and view Gedcom 7 data.

Maybe, it is a compliment for webtrees that the imported Gedcom 7 data already looks so good that I forgot the context :-)

@fisharebest
Copy link
Owner

I think it is probably a bug. The comment was really to myself, to record my initial investigation.

@chtiland
Copy link

chtiland commented Jul 7, 2024

Hi !

The code is using the GEDCOM 5.5.1 definition of ROLE_IN_EVENT, not the GEDCOM 7.0 defintion.

GEDCOM 5.5.1 Definition :

ROLE_IN_EVENT

[ CHIL | HUSB | WIFE | MOTH | FATH | SPOU | ( <ROLE_DESCRIPTOR> ) ]

Indicates what role this person played in the event that is being cited in this context. For example, if you cite a child's birth record as the source of the mother's name, the value for this field is "MOTH." If you describe the groom of a marriage, the role is "HUSB." If the role is something different than one of the six relationship role tags listed above then enclose the role name within matching parentheses.

As I understand, we should be able to add other ROLE limited to 15 chars (braces included I presume) no ?

I still don't understand why there's no role "MAIN" nor for the declarant (eg. on birth act this should be father, mother, an uncle, or anybody else. And when this declarant is not the father, this one is quoted with some information like occupation, age... and so when reporting this information on this other individual -> more or less linked to issue about citation see #5006 )

I'm using Webtrees 2.1.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants