Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict on the Smokeview Technical Reference Guide in p. 35 section 3.5.1 #943

Open
TopiR opened this issue Feb 11, 2020 · 3 comments
Open
Assignees

Comments

@TopiR
Copy link

TopiR commented Feb 11, 2020

This is not isue on the smokeview itself but on it's documentation and more specific on The Technical Reference Guide.
The document's section 3.5.1 presents two FED calculation examples and graphs for both Figure 3.14 but there are three things that I dont't know are those intentionals or not:

  1. The formulas (3.20) and (3.21) are not equal
  2. The unit for time in the example is second instead minute as the previous section 3.5 describes
  3. The Figures 3.14 first graph for ambient doesn't match if calculated using parameters given at the end of section 3.5.1. On the other hand the graph seems to match if using values CO=0ppm, CO2=9% and 02=21%.
    In attachment there is plotted graph which is the same scale as the Figure 3.14 and on the background "brown line" is the graph from Reference Guide. The other smoke filled room graph seems to fine besides the time unit.

FED_example

@rmcdermo
Copy link
Contributor

Thanks, we will take a look.

@gforney gforney self-assigned this Feb 11, 2020
@gforney
Copy link
Contributor

gforney commented Feb 11, 2020

I'll take a look

NexusQuile added a commit to NexusQuile/smv that referenced this issue Apr 21, 2023
NexusQuile added a commit to NexusQuile/smv that referenced this issue Apr 21, 2023
@NexusQuile
Copy link
Contributor

The errors still appear in the current version of the technical reference guide and I agree with TopiR's analysis.

I've created a pull request for the fixed equation and correcting the input values for the ambient exmaple.

However the x-axis lables in Figure 3.14 a) and b) still need correcting.

mcgratta added a commit that referenced this issue Apr 21, 2023
Fix error in total FED equation as per ticket #943
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants