-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflict on the Smokeview Technical Reference Guide in p. 35 section 3.5.1 #943
Comments
Thanks, we will take a look. |
I'll take a look |
NexusQuile
added a commit
to NexusQuile/smv
that referenced
this issue
Apr 21, 2023
Missing addition sign
NexusQuile
added a commit
to NexusQuile/smv
that referenced
this issue
Apr 21, 2023
…#943 CO and CO_2 values were inverted originally.
The errors still appear in the current version of the technical reference guide and I agree with TopiR's analysis. I've created a pull request for the fixed equation and correcting the input values for the ambient exmaple. However the x-axis lables in Figure 3.14 a) and b) still need correcting. |
mcgratta
added a commit
that referenced
this issue
Apr 21, 2023
Fix error in total FED equation as per ticket #943
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is not isue on the smokeview itself but on it's documentation and more specific on The Technical Reference Guide.
The document's section 3.5.1 presents two FED calculation examples and graphs for both Figure 3.14 but there are three things that I dont't know are those intentionals or not:
In attachment there is plotted graph which is the same scale as the Figure 3.14 and on the background "brown line" is the graph from Reference Guide. The other smoke filled room graph seems to fine besides the time unit.
The text was updated successfully, but these errors were encountered: