Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's a problem with vertical japanese text #420

Open
uomar8 opened this issue Dec 28, 2023 · 3 comments
Open

There's a problem with vertical japanese text #420

uomar8 opened this issue Dec 28, 2023 · 3 comments
Milestone

Comments

@uomar8
Copy link
Contributor

uomar8 commented Dec 28, 2023

I used this image as test
horizontal-and-vertical-writing

Once I tried horizontal text it's perfect
Screenshot_20231228_135017_com android gallery3d_edit_610171250828247

Once I tried virtcal text both jp and jp rtl couldn't read it on the correct order
Screenshot_20231228_135134
Screenshot_20231228_135058_com android gallery3d_edit_610156373964707

@firemaples
Copy link
Owner

I have yet to investigate how to support vertical Japanese texts. (by native support from the libraries or calculating the positions in code)
But the result from the last screenshot you posted is better than I expected. At least it read vertically, but the ordering is wrong. 🤔

@uomar8
Copy link
Contributor Author

uomar8 commented Jan 19, 2024

I think this could be an easy solution
Just rotate the cropped bitmap and it will work fine
Screenshot_20240119_103743_com android gallery3d_edit_650912938911613

https://stackoverflow.com/questions/52623765/ml-kit-android-text-recognition-text-orientation

@firemaples
Copy link
Owner

firemaples commented Jan 21, 2024

I think this could be an easy solution Just rotate the cropped bitmap and it will work fine

Wait..., this solution is amazing!!! 🚀
Thank you for the investigation 😍

I'm working on a refactoring task, let me pick this task after the main components work and are stable.

@firemaples firemaples added this to the v4.1.0 milestone Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants