-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestions to improve translate area #419
Comments
Thank you for the suggestions. I think 2 is a feasible solution and would not be hard to implement if I create a rectangle area based on the drawing area. Not sure it is easy to crop an irregular shape. 🤔 Solution 1 is also good, and it could avoid triggering the back gesture on the edge of the screen. Solution 3 is also a possible solution, but the result may be worse than selecting a part of the screen to be translated. For solution 4. The selection view was designed to support multiple selection areas, but I don't know how to arrange multiple results on the screen in a better way. 😅 If I implement 1 or 2, I will keep an option for users to choose which they want. What do you think? |
Yes you're right Google Translate app had the same approach I agree with what you said approach 2 would look nice, we could skip 1 for now Isn't allowed to use irregular shape image? 😅 About 4 😅 i have an idea I hope it's possible to swipe outside the window to switch to the nearest area |
Wow, this idea sounds great! Let me think about this 👍 |
About auto create translate area 1- Instead of Area selection view as (Floating view) we will make it into Fullscreen imagview (activity) 2- we will do the same as this tutorial Or if it's possible to use bounding box with Area selection view and user can edit could be a good idea as well I didn't test it out yet 😅 to make sure the results are good or bad, what do you think? |
I feel I can try to implement them after the selection screen is also refactored to Compose version to check the feasibility and UX. Then, I'll start to refactor the language selection window and the selection view, then implement vertical Japanese recognition, and then start looking into/trying to implement the solutions you proposed, thank you! 🙇♂️ |
I think choosing translate area should be improved and here are some suggestions
1- Instead of swiping to create translate area it could be done by two clicks one at the beginning and one at the end
2- draw to create translate area
3- auto create translate area
4- multiple areas and multiple translate pages
The text was updated successfully, but these errors were encountered: