Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dictionary like in Kaku #268

Open
KonstantinDjairo opened this issue Apr 18, 2023 · 7 comments
Open

dictionary like in Kaku #268

KonstantinDjairo opened this issue Apr 18, 2023 · 7 comments
Assignees
Milestone

Comments

@KonstantinDjairo
Copy link

KonstantinDjairo commented Apr 18, 2023

i know that we could use mdict on android, but it does not work with phrases or anything that is not a word alone
if we have something like 納期に間に合わせるため it won't work on mdict

the way kaku works with whole phrases is awesome, it allows you to click and see the meaning in dictionary, instead of a translating.

https://imgur.com/a/a5s3CWk

sorry about my bad english btw

@uomar8
Copy link
Contributor

uomar8 commented Apr 19, 2023

No need to apologize for your English

That would be helpful, the main focus was on translate
But advanced dictionary is a good thing to have

I will try to work on it and see what will happen

@firemaples
Copy link
Owner

firemaples commented Apr 24, 2023

i know that we could use mdict on android, but it does not work with phrases or anything that is not a word alone if we have something like 納期に間に合わせるため it won't work on mdict

the way kaku works with whole phrases is awesome, it allows you to click and see the meaning in dictionary, instead of a translating.

https://imgur.com/a/a5s3CWk

sorry about my bad english btw

My English is also bad 😅, it is just a negotiation tool.

It's a great suggestion. 👍
I also want to have the feature you mentioned.

I just moved to Japan, but I don't understand the Japanese language, so I also use this app heavily these days.
It would be very helpful if I could add this feature to EverTranslator.

Let me check how Kaku works and how to implement it in this application.
Thanks for the suggestion. 😆

No need to apologize for your English

That would be helpful, the main focus was on translate But advanced dictionary is a good thing to have

I will try to work on it and see what will happen

Thanks for your help.
Do you have any idea about it? 🤔

@firemaples firemaples self-assigned this Apr 24, 2023
@firemaples firemaples added this to the v3.1.14 milestone Apr 24, 2023
@KonstantinDjairo
Copy link
Author

i know that we could use mdict on android, but it does not work with phrases or anything that is not a word alone if we have something like 納期に間に合わせるため it won't work on mdict
the way kaku works with whole phrases is awesome, it allows you to click and see the meaning in dictionary, instead of a translating.

https://imgur.com/a/a5s3CWk

sorry about my bad english btw

My English is also bad sweat_smile, it is just a negotiation tool.

It's a great suggestion. +1 I also want to have the feature you mentioned.

I just moved to Japan, but I don't understand the Japanese language, so I also use this app heavily these days. It would be very helpful if I could add this feature to EverTranslator.

Let me check how Kaku works and how to implement it in this application. Thanks for the suggestion. laughing

No need to apologize for your English
That would be helpful, the main focus was on translate But advanced dictionary is a good thing to have
I will try to work on it and see what will happen

Thanks for your help. Do you have any idea about it? thinking

ありがとうございます!!

@uomar8
Copy link
Contributor

uomar8 commented Apr 25, 2023

Thanks for your help. Do you have any idea about it? 🤔

I do have one what I noticed is the word detection is really good it can detect Japanese words as good as Kaku
Screenshot_20230425_045814
Screenshot_20230425_045834

The only thing Kaku can achieve is clicking inside the word
Screenshot_20230425_045847

And how we could achieve that is to recheck the words but remove what's before the clicked letter
Screenshot_20230425_050630_com example android notepad_edit_5048374310687

And in the settings we could choose between dictionary and web
Or button to switch between them

@KonstantinDjairo
Copy link
Author

KonstantinDjairo commented Apr 26, 2023

Thanks for your help. Do you have any idea about it? thinking

I do have one what I noticed is the word detection is really good it can detect Japanese words as good as Kaku Screenshot_20230425_045814 Screenshot_20230425_045834

The only thing Kaku can achieve is clicking inside the word Screenshot_20230425_045847

And how we could achieve that is to recheck the words but remove what's before the clicked letter Screenshot_20230425_050630_com example android notepad_edit_5048374310687

And in the settings we could choose between dictionary and web Or button to switch between them

you could add jmdict, so it would be a built-in dictionary, like in kaku, this is what make kaku so fast to use.
i noticed that they put jmdict and kanjidict2 in that location

to implement a JMDict viewer they are parsing the JMDict XML file, creating a local database to store the dictionary entries, and building the UI to display the entries. Fortunately the code is already there and kaku is also writen in kotlin.

Additionally, removing what's before the word would be very annoying, since the purpose is to look up the whole phrase, and it's not sure that the user will always know where a word ends or where it begins, that's why i like the being able to click anywhere in the phrase without "losing the phrase".

@uomar8
Copy link
Contributor

uomar8 commented Apr 26, 2023

Thanks for your help. Do you have any idea about it? thinking

I do have one what I noticed is the word detection is really good it can detect Japanese words as good as Kaku Screenshot_20230425_045814 Screenshot_20230425_045834
The only thing Kaku can achieve is clicking inside the word Screenshot_20230425_045847
And how we could achieve that is to recheck the words but remove what's before the clicked letter Screenshot_20230425_050630_com example android notepad_edit_5048374310687
And in the settings we could choose between dictionary and web Or button to switch between them

you could add jmdict, so it would be a built-in dictionary, like in kaku, this is what make kaku so fast to use. i noticed that they put jmdict and kanjidict2 in that location

to implement a JMDict viewer they are parsing the JMDict XML file, creating a local database to store the dictionary entries, and building the UI to display the entries. Fortunately the code is already there and kaku is also writen in kotlin. Additionally, removing what's before the word would be very annoying, since the purpose is to look up the whole phrase, and it's not sure that the user will always know where a word ends or where it begins, that's why i like the being able to click anywhere in the phrase without "losing the phrase".

Yes, you're right I didn't mean remove same as my picture it will be the same as Kaku, where you click is where it will start to check the phrase and it, it's just to figure out how to code it

JMDict only support japanese language what do you think of instead of that

Once you click on the word it will open for example
https://www.japandict.com/%E4%BB%8A%E6%97%A5%E3%81%AF?lang=eng
And if you click on English word it will open
https://dictionary.cambridge.org/dictionary/english/hello

@KonstantinDjairo
Copy link
Author

KonstantinDjairo commented Apr 26, 2023

Yes, but a lot of dictionaries uses the same format as jmdict, also, opening the browser for searching a word is rather slow than just displaying the respective dictionary entry.
Pretty much any dictionary can be found in the freemdict website,not only japanese.

@firemaples firemaples modified the milestones: v3.1.14, v3.1.15 May 5, 2023
@firemaples firemaples modified the milestones: v3.1.15, v3.1.16 May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants