Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope use_host_cpuid_function refactoring #1019

Closed
serban300 opened this issue Mar 18, 2019 · 4 comments · Fixed by #1362
Closed

Scope use_host_cpuid_function refactoring #1019

serban300 opened this issue Mar 18, 2019 · 4 comments · Fixed by #1362
Assignees
@serban300
Labels
Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled
Milestone
AMD Support

Comments

@serban300
Copy link
Contributor

serban300 commented Mar 18, 2019 •
edited
Loading

The function was introduced as part of #1015

Try to refactor it in order to edit the cpuid in place

See this comments:
#1015 (comment)

#1015 (comment)
@serban300 serban300 added this to the AMD Support milestone Mar 18, 2019
@serban300 serban300 self-assigned this Mar 18, 2019
@serban300 serban300 mentioned this issue Mar 18, 2019
Merged
@serban300 serban300 added the Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled label Mar 27, 2019
@serban300
Copy link
Contributor Author

I added the following PR for kvm-ioctls: rust-vmm/kvm#6

@serban300
Copy link
Contributor Author

I moved the rust-vmm PR to vmm-sys-util crate: rust-vmm/vmm-sys-util#4

@serban300
Copy link
Contributor Author

I'm waiting for at least another CR for rust-vmm/vmm-sys-util#4
What remains to be done after:

  1. Use FamStructWrapper in kvm-ioctls for Cpuid
  2. Use the new capabilities exposed by FamStructWrapper in use_host_cpuid_function()

@serban300
Copy link
Contributor Author

I posted a PR on kvm-ioctl for implementing the CpuId struct using FamStructWrapper:

rust-vmm/kvm#58

@andreeaflorescu andreeaflorescu mentioned this issue Oct 28, 2019
Closed
2 tasks
@serban300 serban300 mentioned this issue Oct 29, 2019
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serban300 serban300

Labels
Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled
Projects
None yet
Milestone
AMD Support
Development

Successfully merging a pull request may close this issue.

simplify use_host_cpuid_function serban300/firecracker
1 participant
@serban300