From e3c54505233ac4ecc3f524b6490e92964edc971c Mon Sep 17 00:00:00 2001
From: Petro Tiurin <93913847+ptiurin@users.noreply.github.com>
Date: Tue, 10 Sep 2024 11:24:28 +0100
Subject: [PATCH] test(FIR-35179): re-enable some of the fixed tests (#144)

---
 .changes/unreleased/Changed-20240909-160913.yaml  | 3 +++
 tests/functional/adapter/test_basic.py            | 1 -
 tests/functional/adapter/utils/test_data_types.py | 1 -
 tests/functional/adapter/utils/test_utils.py      | 6 +++---
 4 files changed, 6 insertions(+), 5 deletions(-)
 create mode 100644 .changes/unreleased/Changed-20240909-160913.yaml

diff --git a/.changes/unreleased/Changed-20240909-160913.yaml b/.changes/unreleased/Changed-20240909-160913.yaml
new file mode 100644
index 000000000..ebb4e52a6
--- /dev/null
+++ b/.changes/unreleased/Changed-20240909-160913.yaml
@@ -0,0 +1,3 @@
+kind: Changed
+body: Enabled tests that were disabled due to the feature gaps
+time: 2024-09-09T16:09:13.607541+01:00
diff --git a/tests/functional/adapter/test_basic.py b/tests/functional/adapter/test_basic.py
index bfe5a4edd..8d4dd02c3 100644
--- a/tests/functional/adapter/test_basic.py
+++ b/tests/functional/adapter/test_basic.py
@@ -157,7 +157,6 @@ class TestSnapshotTimestampFirebolt(BaseSnapshotTimestamp):
     pass
 
 
-@mark.skip('Firebolt has a bug in LEFT JOIN. FIR-11078')
 class TestBaseAdapterMethod(BaseAdapterMethod):
     pass
 
diff --git a/tests/functional/adapter/utils/test_data_types.py b/tests/functional/adapter/utils/test_data_types.py
index 83f982c1d..6936902bf 100644
--- a/tests/functional/adapter/utils/test_data_types.py
+++ b/tests/functional/adapter/utils/test_data_types.py
@@ -114,7 +114,6 @@ def models(self):
         }
 
 
-@pytest.mark.skip('True boolean is feature-flagged')
 class TestTypeBoolean(BaseTypeBoolean):
     @pytest.fixture(scope='class')
     def models(self):
diff --git a/tests/functional/adapter/utils/test_utils.py b/tests/functional/adapter/utils/test_utils.py
index 98f055465..c6ccd16cc 100644
--- a/tests/functional/adapter/utils/test_utils.py
+++ b/tests/functional/adapter/utils/test_utils.py
@@ -280,12 +280,12 @@ def models(self):
         }
 
 
-@mark.skip('Escaping with backslash is not supported in Firebolt')
+@mark.skip('Escaping with backslash is not supported by default in Firebolt')
 class TestEscapeSingleQuotes(BaseEscapeSingleQuotesBackslash):
     pass
 
 
-@mark.skip('Except is not supported yet')
+@mark.skip('Except is not supported yet. FIR-16223')
 class TestExcept(BaseExcept):
     pass
 
@@ -313,7 +313,7 @@ def models(self):
         }
 
 
-@mark.skip('Intersect is not supported yet')
+@mark.skip('Intersect is not supported yet. FIR-16223')
 class TestIntersect(BaseIntersect):
     pass