Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(messaging, ios): register app delegate with google utilities for swizzling #13525

Merged
merged 4 commits into from
Oct 23, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Oct 21, 2024

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

closes #13287
closes #13476
closes #12978

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@pamafe1976
Copy link

I confirm that this PR fixes #13287

@russellwheatley russellwheatley marked this pull request as ready for review October 23, 2024 09:17
@russellwheatley russellwheatley merged commit 8ff0f88 into main Oct 23, 2024
28 of 29 checks passed
@russellwheatley russellwheatley deleted the messaging-13476 branch October 23, 2024 11:43
Copy link

@niosme niosme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silent notifications works.
Also is not firing twice FirebaseMessaging.onMessage.listen for foreground notifications.
Background notifications works also FirebaseMessaging.onBackgroundMessage

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants