Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fdc): Fix serializing errors #13450

Merged
merged 2 commits into from
Oct 3, 2024
Merged

fix(fdc): Fix serializing errors #13450

merged 2 commits into from
Oct 3, 2024

Conversation

maneesht
Copy link
Contributor

@maneesht maneesht commented Oct 1, 2024

  • Fix issue where on GRPC, since protobuf doesn't distinguish between double and int, all numbers were being parsed as doubles.
  • Fix issue where execute.ignore was called, causing errors not being thrown.

@Lyokone Lyokone merged commit 9a5aba2 into main Oct 3, 2024
22 of 29 checks passed
@Lyokone Lyokone deleted the mtewani/fix-nativefromjson-2 branch October 3, 2024 07:48
@firebase firebase locked and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Lyokone Lyokone Lyokone approved these changes

@cynthiajoan cynthiajoan cynthiajoan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maneesht @cynthiajoan @Lyokone