Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase Unity SDK Samples page does not correctly link to CONTRIBUTING.md #264

Open
rwhogg opened this issue Jul 5, 2022 · 2 comments
Open

Comments

@rwhogg
Copy link

rwhogg commented Jul 5, 2022

What Happened?
On the Unity SDK Samples page, the CONTRIBUTING.md link takes you to https://github.com/firebase/quickstart-unity/tree/master/contributing.md , which 404's.

What Did You Expect to Happen
It should take you to https://github.com/firebase/quickstart-unity/blob/master/CONTRIBUTING.md

Note that the link is correct in the source repo, it's only on firebaseopensource.com that it links incorrectly.

@thatfiredev
Copy link
Member

Thanks for reporting this @rwhogg

It seems like that problem happens with projects that use relative paths (eg. /CONTRIBUTING.md) on their README.
I think that problem could/should be corrected on the firebaseopensource.com side, but I'm not very familiar with this codebase. I'll try to figure out a way to fix that

@thatfiredev
Copy link
Member

cc: @lupas
In case you have any suggestions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants