Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

morphir Char sdk includes toLocaleUpper and toLocaleLower #1151

Open
edwardpeters opened this issue Mar 21, 2024 · 0 comments
Open

morphir Char sdk includes toLocaleUpper and toLocaleLower #1151

edwardpeters opened this issue Mar 21, 2024 · 0 comments
Labels
task Task level project item

Comments

@edwardpeters
Copy link

Describe the bug
The morphir SDK for Char includes a pair of functions toLocaleUpper and toLocalLower. These appear to rely on system-dependent settings, and are not appropriate for the pure functional nature of Morphir. They appear to have been copied from elm-core.

These functions should either be removed, or modified to take the Locale as a parameter. References to them may be found in https://github.com/finos/morphir-elm/blob/main/src/Morphir/IR/SDK/Char.elm and few other morphir-elm files.

@edwardpeters edwardpeters added the task Task level project item label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Task level project item
Projects
None yet
Development

No branches or pull requests

1 participant