Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debate moving urls of co-ords plugins into real config #129

Open
james-rae opened this issue Jul 31, 2019 · 0 comments
Open

Debate moving urls of co-ords plugins into real config #129

james-rae opened this issue Jul 31, 2019 · 0 comments
Labels
needs: more info priority: low question Further information is requested

Comments

@james-rae
Copy link
Member

The urls to lookup co-ordinate info are hardcoded in the plugin (see top of index.ts). Which means if we need to adjust them, it requires a re-build of RAMP.

Ideally they would reside in the viewer config under plugins.coordInfo (or whatever the proper name is for the plugin).

However, this does add an extra step in using the plugin (add the plugin, plus add the config element). It won't work without it. Side thought: do plugins need an optional "how to setup" doc feature for people?

@james-rae james-rae added question Further information is requested priority: low needs: more info labels Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: more info priority: low question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant