Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elevation not used in calculations #49

Open
ArrEssJay opened this issue Apr 13, 2022 · 1 comment
Open

Elevation not used in calculations #49

ArrEssJay opened this issue Apr 13, 2022 · 1 comment

Comments

@ArrEssJay
Copy link

ArrEssJay commented Apr 13, 2022

Sun and moon positions are (to a greater or lesser extent) dependent on elevation as well as latitude/longitude. The suncalc library used accepts an optional height parameter, defaulting to the geodetic surface.

It would be useful if this plugin could additionally store and use an elevation parameter (or estimate it from an elevation model) for more accurate calculations.

@fetzerch
Copy link
Owner

fetzerch commented Nov 6, 2022

Remark: suncalc only supports this in getTimes (which is currently only used for annotations). The request to add support also to getPosition: mourner/suncalc#141 is still open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants