Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have tools put version in CREATOR keyword #28

Open
donhorner opened this issue Mar 7, 2019 · 5 comments
Open

Have tools put version in CREATOR keyword #28

donhorner opened this issue Mar 7, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@donhorner
Copy link

When looking at another issue, I compared the output of gltcube to a very old version of the ScienceTools. I realized that the tools no longer put the version of the tools in the CREATOR keyword, just "HEAD". Here's an example:

< card 25: CREATOR = 'gtltcube ScienceTools-v9r23p1-fssc-20110726'

card 25: CREATOR = 'gtltcube HEAD'

We should figure out how to restore this functionality and get a proper version into the CREATOR string.

@donhorner donhorner added the enhancement New feature or request label Mar 7, 2019
@jasercion
Copy link
Contributor

Talked with Eric about this. Apparently I won't be able to co-opt the way this was originally done, as it was dependent on a specific functionality of CVS (replacement of reserved string upon checkout). I'll work on figuring out a better way to go about getting that Keyword updated with the correct tag.

@jasercion
Copy link
Contributor

jasercion commented Apr 4, 2019

@brianv0 When repoman clones all of the repositories does it have some sort of git config environment that it sets up for itself? Would it be possible to tell repoman to set up a git smudge filter (see section on keyword expansion) to handle this CVS keyword substitution in our new git system?

@jasercion
Copy link
Contributor

I've been able to get this to work locally but I have to change my local git config directly so I was hoping this could be automated by repoman.

@donhorner
Copy link
Author

I noticed that if you run gtbin, it tells you

This is gtbin version HEAD

The tool gtbindef does the same. We should probably check for tools that do this and make sure they are fixed when we figure this out.

@jasercion
Copy link
Contributor

This still needs to be fixed. Going to add this as a low priority enhancement for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants