#178 Ammendment: from_userstring inside luaZ_fill #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daurnimator
reviewed
Jun 2, 2020
| @@ -50,6 +51,8 @@ const luaZ_fill = function(z) { | |||
| let buff = z.reader(z.L, z.data); | |||
| if (buff === null) | |||
| return EOZ; | |||
| // convert to lua_string | |||
| buff = from_userstring(buff); | |||
| lua_assert(buff instanceof Uint8Array, "Should only load binary of array of bytes"); | |||
There was a problem hiding this comment.
should remove this assert; from_userstring does it for us
Yeah no problem it wasn't mine to PR :P 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution suggested by @daurnimator , PR'd by me :)
This should close #178