Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Hashable module to separate library #5

Open
paluh opened this issue Oct 7, 2018 · 4 comments
Open

Extract Hashable module to separate library #5

paluh opened this issue Oct 7, 2018 · 4 comments

Comments

@paluh
Copy link

paluh commented Oct 7, 2018

It seems that Data.Hashable can be useful on its own and that currently PureScript ecosystem lacks library with similar scope.
Do you think that this module is really generic or I'm missing something?
What do you think about publishing it as a separate library?

@fehrenbach
Copy link
Owner

Yes, it could be in a separate library.

The reason it isn't, is that I really want Hashable to be in the prelude and add compiler support for deriving instances, just like Ord.

I suppose now is as good a time as any to start that discussion.

@paluh
Copy link
Author

paluh commented Oct 8, 2018

@fehrenbach thanks for quick response!

I think that separating library could be a good step even before this compiler integration related discussion...

For sure it could be a good step from my (read "user") perspective ;-)

@fehrenbach
Copy link
Owner

I'll consider it if the prelude discussion/decision drags on for too long.

In the meantime, is there a reason to not just depend on this library?

@paluh
Copy link
Author

paluh commented Oct 11, 2018

@fehrenbach Yeah, I'm depending on the whole library right now and it's not a problem at all for me 😉
I've opened this issue because I thought that this module just would be a good addition to the PS ecosystem...
Should I close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants