Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependent_version? #32

Open
axilleas opened this issue Sep 11, 2014 · 0 comments
Open

Drop dependent_version? #32

axilleas opened this issue Sep 11, 2014 · 0 comments

Comments

@axilleas
Copy link
Member

Is there any reason to have dependent_version in the Dependency table? Currently this is used in places that do not add anything to the app:

> ack dependent_version app/
app/models/ruby_gem.rb
64:        d.dependent_version = dep['requirements']

app/models/fedora_rpm.rb
207:      d.dependent_version = 

With current implementation of obtaining the build dependencies (parsing spec file), we sometimes end up with double dependencies, with only difference their version.

Example: mail is picked twice because of spec file definition.

FedoraRpm.find_by(name: 'rubygem-actionmailer').dependencies

+------+-------------+------------+-------------------+-------------------------+-------------------------+------------+--------------+
| id   | environment | dependent  | dependent_version | created_at              | updated_at              | package_id | package_type |
+------+-------------+------------+-------------------+-------------------------+-------------------------+------------+--------------+
| 9894 | development | mocha      |                   | 2014-09-07 03:18:30 UTC | 2014-09-07 03:18:30 UTC | 143        | FedoraRpm    |
| 9893 | development | minitest   |                   | 2014-09-07 03:18:18 UTC | 2014-09-07 03:18:18 UTC | 143        | FedoraRpm    |
| 9892 | development | mail       | < 2.6             | 2014-09-07 03:18:06 UTC | 2014-09-07 03:18:06 UTC | 143        | FedoraRpm    |
| 9891 | development | mail       | >= 2.5.3          | 2014-09-07 03:17:54 UTC | 2014-09-07 03:17:54 UTC | 143        | FedoraRpm    |
| 9890 | development | actionview | = 4.1.5           | 2014-09-07 03:17:42 UTC | 2014-09-07 03:17:42 UTC | 143        | FedoraRpm    |
| 9889 | development | actionpack | = 4.1.5           | 2014-09-07 03:17:31 UTC | 2014-09-07 03:17:31 UTC | 143        | FedoraRpm    |
| 9888 | runtime     | actionview |                   | 2014-09-07 03:17:02 UTC | 2014-09-07 03:17:02 UTC | 143        | FedoraRpm    |
| 9887 | runtime     | actionpack |                   | 2014-09-07 03:17:02 UTC | 2014-09-07 03:17:02 UTC | 143        | FedoraRpm    |
| 9886 | runtime     | mail       |                   | 2014-09-07 03:17:02 UTC | 2014-09-07 03:17:02 UTC | 143        | FedoraRpm    |
+------+-------------+------------+-------------------+-------------------------+-------------------------+------------+--------------+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant