Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message body for push notifications contains misleading information #1089

Open
penguinpee opened this issue Feb 20, 2024 · 0 comments
Open

Comments

@penguinpee
Copy link

penguinpee commented Feb 20, 2024

I have a rule for sending notifications by e-mail for certain applications. Pagure being one of them.

Whenever Packit creates a new branch for opening a package update PR, I receive a notification of that activity. While the subject of that message correctly states packit pushed N commits, the body of the message uses a different author. Presumably it's the author of the last real change committed.

To make all this more tangible, here's the message (relevant parts):

Subject: [Pagure] packit pushed 23 commits on forks/packit/rpms/python-plotnine
         (branch:  0.13.0-rawhide-update-pull_from_upstream)

Benjamin Beasley (music) pushed 23 commits on forks/packit/rpms/python-plotnine.
Branch: 0.13.0-rawhide-update-pull_from_upstream

https://src.fedoraproject.org/fork/packit/rpms/python-plotnine/c/%5E0000000000000000000000000000000000000000..1f4a886e9dfb621be00046521b80b51ddc5a9dca

-- 
Sent by Fedora Notifications: https://notifications.fedoraproject.org/rules/86

Benjamin Beasley (music) was the last to commit any real changes. Somehow, the two empty mass rebuild commits following that commit are ignored.

Please note, that the link at the bottom of the message is not accessible. That, however, is something I can live with. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant