Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Corrects incorrect URLs to Sergey Sova's site #741

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

AntonAmbarov
Copy link
Contributor

Past url invalid https://sova.dev/ru/why-utils-and-helpers-is-a-dump/

Background

Changelog

Copy link

netlify bot commented Oct 21, 2024

👷 Deploy request for pr-fsd pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 6079feb

@illright
Copy link
Member

Thanks! Sergey Sova has a new domain, so we can actually change the link to the Russian version: https://sergeysova.com/ru/why-utils-and-helpers-is-a-dump/

Could you also replace other references to sova.dev in the project with sergeysova.com please?

@sanua356
Copy link
Contributor

@illright Hello. Can you take a look at pull request #711 ? I changed the structure of the article about a month ago, but it remained without review.

@AntonAmbarov
Copy link
Contributor Author

Thanks! Sergey Sova has a new domain, so we can actually change the link to the Russian version: https://sergeysova.com/ru/why-utils-and-helpers-is-a-dump/

Could you also replace other references to sova.dev in the project with sergeysova.com please?

Yeah, no problem

@AntonAmbarov AntonAmbarov changed the title fix(docs): fixes invalid URL for link to utility dump fix(docs): Corrects incorrect URLs to Sergei Sova's site Oct 23, 2024
@AntonAmbarov AntonAmbarov changed the title fix(docs): Corrects incorrect URLs to Sergei Sova's site fix(docs): Corrects incorrect URLs to Sergey Sova's site Oct 23, 2024
@AntonAmbarov
Copy link
Contributor Author

@illright I replaced the domain sova.dev with sergeysova.com

Copy link
Member

@illright illright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@illright illright merged commit 6ffd3d1 into feature-sliced:master Oct 24, 2024
2 checks passed
@AntonAmbarov AntonAmbarov deleted the patch-1 branch October 24, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants