Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between the paper and codes #7

Open
zjngjng opened this issue May 12, 2023 · 2 comments
Open

Inconsistency between the paper and codes #7

zjngjng opened this issue May 12, 2023 · 2 comments

Comments

@zjngjng
Copy link

zjngjng commented May 12, 2023

the paper says that NNCCS value range is shifted from [-1,+1] to [ε, 2+ε] by adding a 1+ε term, however, the codes didn't add this term max_negative_cloned[index,label.view(-1)]= -1e-12, do we need to add 1+ε for quality score?

@fdbtrs
Copy link
Owner

fdbtrs commented Jun 1, 2023

you need to +1 if you train the model. For prediction/testing, it is not needed

@davidmcarreira
Copy link

@fdbtrs your answer is not clear. Can you please reference where, in your code, you shift the NNCCS values as reported in the paper?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants