Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remark element erroneously mapped to HTML mark element #13

Open
fbolton opened this issue Dec 22, 2016 · 2 comments
Open

remark element erroneously mapped to HTML mark element #13

fbolton opened this issue Dec 22, 2016 · 2 comments

Comments

@fbolton
Copy link
Owner

fbolton commented Dec 22, 2016

DocBookRx maps <remark>REVISIT</remark> to #REVISIT#, which renders in HTML as <mark>REVISIT</mark> (yellow highlighted text). But this is not what is intended by the remark element. Better would be to map remarks to comments (i.e. preceded by //).
@fbolton
Copy link
Owner Author

fbolton commented Dec 23, 2016

Preserved the mapping of remarks to marked text, but also enclosed the remarks in an ifdef::showremarks[] block. If you want the remarks to become visible, just set the showremarks attribute.

@fbolton
Copy link
Owner Author

fbolton commented Dec 23, 2016

Fixed by commit 98edb89

@fbolton fbolton closed this as completed Dec 23, 2016
@fbolton fbolton reopened this Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fbolton