Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoboard: peer IDs should be supplied by the user #188

Open
vmatare opened this issue Dec 9, 2019 · 2 comments
Open

protoboard: peer IDs should be supplied by the user #188

vmatare opened this issue Dec 9, 2019 · 2 comments
Labels
pinned Issue will not be closed by stale bot

Comments

@vmatare
Copy link
Contributor

vmatare commented Dec 9, 2019

Currently, peers are identified by count, and they are counted simply in the order in which the CreatePeerMessages are processed. This leads to a certain degree of uncertainty as to what peer will have what ID. One idea for a solution would be to give the peers a user-supplied string identifier.

@stale
Copy link

stale bot commented Jan 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix We won't fix this issue label Jan 8, 2020
@morxa morxa added pinned Issue will not be closed by stale bot and removed wontfix We won't fix this issue labels Jan 9, 2020
@morxa
Copy link
Member

morxa commented Feb 14, 2020

This just bit another group, as they used the wrong peer to send messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Issue will not be closed by stale bot
Projects
None yet
Development

No branches or pull requests

2 participants