Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change unittest to pytest #192

Open
wants to merge 111 commits into
base: dev
Choose a base branch
from
Open

Change unittest to pytest #192

wants to merge 111 commits into from

Conversation

daklauss
Copy link
Collaborator

@daklauss daklauss commented Dec 3, 2024

ronald-jaepel and others added 30 commits June 18, 2024 21:13
Previously, there were two interfaces in the `OptimizationProblem` for calling evaluation functions (e.g. objectives): one for evaluating individuals, and one for populations.
To simplify the code base, these two methods were now unified.
To ensure backward compatibility, a 1D-Array is returned if a single individual is passed to the function.
Previously, the cadet path set in Cadet(install_path="path") was not inherited into cadet instances created from the run() method.
Fix and extend tests about .calculate_interstitial_rt/velocity
Previously, this was required because CADET-Core was not setting the
PATH correctly.
Now, this can lead to inconsistent behaviour.
Note, this requires CADET>4.4.0
Recently, the option to (not) plot the time axis using minutes was
introduced.
This commit fixes some methods that were not properly implemented.
Moreover, the name of the flag was changed from `use_minutes` to
`x_axis_in_minutes` to make clear that only plotting is affected and not
other parameter values (e.g. start and end times).
Updates and Fixes plot_at_position by adding start, end and
x_axis_in_minutes as parameters in solution.py
@daklauss daklauss force-pushed the 189-migrate-testing-to-pytest branch from 7d17307 to fbc1c10 Compare December 4, 2024 16:33
@daklauss daklauss force-pushed the 189-migrate-testing-to-pytest branch from fbc1c10 to 7ab2fed Compare December 4, 2024 18:06
@daklauss daklauss changed the base branch from master to dev December 4, 2024 18:09
@daklauss daklauss force-pushed the 189-migrate-testing-to-pytest branch 2 times, most recently from 73f3404 to 3e7f58b Compare December 5, 2024 09:03
@daklauss daklauss changed the title Change unittest to pytest and using coverage Change unittest to pytest Dec 10, 2024
@daklauss daklauss force-pushed the 189-migrate-testing-to-pytest branch from 994a3a7 to da4976b Compare December 10, 2024 13:25
@daklauss
Copy link
Collaborator Author

daklauss commented Dec 10, 2024

Removed coverage for a later issue #144.
grafik
https://github.com/fau-advanced-separations/CADET-Process/actions/runs/12177180699/job/33964452874

Pytest with coverage as i used needs way to long for a simple push (~50%). Considering using it just on merge or action.

Pytest alone should work.

@daklauss daklauss requested a review from schmoelder December 10, 2024 13:44
Replace link to default conda with link to mini-forge
pyproject.toml Outdated Show resolved Hide resolved
@schmoelder
Copy link
Contributor

This one here could also be marked as slow (for now):

@pytest.mark.parametrize("process", test_cases, indirect=True)

@daklauss daklauss force-pushed the 189-migrate-testing-to-pytest branch from da4976b to 2809904 Compare December 12, 2024 17:36
@daklauss
Copy link
Collaborator Author

Done

This one here could also be marked as slow (for now):

@pytest.mark.parametrize("process", test_cases, indirect=True)

and removed coverage from dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate testing to pytest
7 participants