Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Low priority] CADET-process gives confusing progress reports for SLSQP() #132

Open
hannahlanzrath opened this issue Apr 22, 2024 · 1 comment

Comments

@hannahlanzrath
Copy link
Collaborator

hannahlanzrath commented Apr 22, 2024

Not sure if this is really an issue, just something I noticed.

Depending on the type of Jacobian there are 2-3 evaluations per optimization step for SLSQP(). When using the cadet-process optimizer with SLSQP() the progress report by the callback_function defined in scipyAdapter.py will only ever report the last evaluation of one optimization step (I think?). This leads to the given x0 seemingly not being evaluated, which confused me a little as I thought I would be giving it in the wrong format or something similar, although when debugging I saw that all 3 evaluations are performed correctly.

image

From using other optimizers the user might expect to see the chosen x0 evaluation in the first iteration.

EDIT:

The issue might be more important than initially thought, because the last function value of the SLSQP() is not given as the result.x but rather the last assessment of the gradient is given as a result.

@schmoelder
Copy link
Contributor

Hi Hannah, could you please provide an MRE?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants