Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CacheOverride Simplifications #1052

Open
guybedford opened this issue Nov 22, 2024 · 2 comments · May be fixed by #1051
Open

CacheOverride Simplifications #1052

guybedford opened this issue Nov 22, 2024 · 2 comments · May be fixed by #1051

Comments

@guybedford
Copy link
Member

We could simplify the CacheOverride interface with the following steps:

  1. Make the first string arg optional - replace new CacheOverride('override', { ... }) with just new CacheOverride({ ... })
  2. Treat new CacheOverride('none') as just cacheOverride: null | undefined or otherwise
  3. Treat new CacheOverride('pass') as just cacheOverride: 'pass' or even cache: 'no-store' per Support fetch cache option #1050
  4. Support the CacheOverride being passed as an interface of options directly instead of having to have it explicitly constructed

With the above, we could then potentially deprecate the constructor in due course.

@guybedford
Copy link
Member Author

(1) here is implemented in #1051.

@guybedford
Copy link
Member Author

All of these features are now fully implemented in #1051.

@guybedford guybedford linked a pull request Jan 18, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant