Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Add allow_leading_plus and skip_white_space in chars_format #275

Closed
dalle opened this issue Nov 15, 2024 · 3 comments · Fixed by #280
Closed

Feature request: Add allow_leading_plus and skip_white_space in chars_format #275

dalle opened this issue Nov 15, 2024 · 3 comments · Fixed by #280

Comments

@dalle
Copy link
Collaborator

dalle commented Nov 15, 2024 •
edited
Loading

  • Remove/deprecate the defines FASTFLOAT_ALLOWS_LEADING_PLUS and FASTFLOAT_SKIP_WHITE_SPACE.
  • Add allow_leading_plus and skip_white_space in chars_format.
  • [Add an additional from_chars_advanced for integer types where the format options can be set.]

There may be different needs in different parts of the program using the fast_float library.
@lemire
Copy link
Member

lemire commented Nov 15, 2024

Pull request invited.

@dalle
Copy link
Collaborator Author

dalle commented Nov 20, 2024

Working on a PR for this, I also found some issues with is_space and "nan"/"inf" parsing for non char strings.

@dalle
Copy link
Collaborator Author

dalle commented Nov 20, 2024 •
edited
Loading

I have created a branch (issue275-deprecate-feature-macros) which is based on changes in #279

@dalle dalle mentioned this issue Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add allow_leading_plus and skip_white_space in chars_format dalle/fast_float
2 participants
@lemire @dalle