Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warning on Clang with -Wdeprecated-redundant-constexpr-static-def #254

Closed
stephenberry opened this issue Jul 22, 2024 · 7 comments · Fixed by #268
Closed

Build warning on Clang with -Wdeprecated-redundant-constexpr-static-def #254

stephenberry opened this issue Jul 22, 2024 · 7 comments · Fixed by #268

Comments

@stephenberry
Copy link

out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated

Enabling -Wdeprecated-redundant-constexpr-static-def with warnings as errors causes fast_float to not build on Clang.

Fixing this should make the code cleaner as well.

@lemire
Copy link
Member

lemire commented Jul 22, 2024

@stephenberry pull request invited!

@stephenberry
Copy link
Author

I think to support C++11 you would need macros around the old expressions. Do you want this?

@lemire
Copy link
Member

lemire commented Jul 23, 2024

The library is C++11 and we do not want to change this.

Using macros is acceptable.

@lemire lemire changed the title Build failure on Clang with -Wdeprecated-redundant-constexpr-static-def Build warning on Clang with -Wdeprecated-redundant-constexpr-static-def Aug 22, 2024
@dalle
Copy link
Collaborator

dalle commented Nov 23, 2024

I can't reproduce this issue anymore, any more details on versions used @stephenberry?

@stephenberry
Copy link
Author

This issue was reported for version 6.1.3, perhaps someone fixed it. Are you making sure to build with C++17 or later?

@dalle
Copy link
Collaborator

dalle commented Nov 23, 2024

This was fixed in #268 for release 6.1.5.

@dalle
Copy link
Collaborator

dalle commented Nov 23, 2024

Thank you for your report, I'm closing this issue.

@dalle dalle closed this as completed Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants