-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build warning on Clang with -Wdeprecated-redundant-constexpr-static-def #254
Comments
@stephenberry pull request invited! |
I think to support C++11 you would need macros around the old expressions. Do you want this? |
The library is C++11 and we do not want to change this. Using macros is acceptable. |
I can't reproduce this issue anymore, any more details on versions used @stephenberry? |
This issue was reported for version |
This was fixed in #268 for release 6.1.5. |
Thank you for your report, I'm closing this issue. |
out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated
Enabling
-Wdeprecated-redundant-constexpr-static-def
with warnings as errors causes fast_float to not build on Clang.Fixing this should make the code cleaner as well.
The text was updated successfully, but these errors were encountered: