Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add feature to tell which fieldset tab(s) has the validation error #507

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add feature to tell which fieldset tab(s) has the validation error #507

wants to merge 2 commits into from

Conversation

EricOuma
Copy link

Fixes issue #506

As demonstrated by the image below, users will immediately know which tab(s) have the errors.

Screenshot from 2023-09-10 13-29-34

@jamesgilmorelyst jamesgilmorelyst added the bug Something isn't working label Mar 23, 2024
@jamesgilmorelyst jamesgilmorelyst linked an issue Mar 23, 2024 that may be closed by this pull request
form error message does not hit the tab with the error #506
Open
@jamesgilmorelyst jamesgilmorelyst added the enhancement New feature or request label Mar 23, 2024
@katiam2
Copy link
Collaborator

katiam2 commented Dec 1, 2024

Hey @EricOuma! 👋
dusts off this PR Wow, time really flies! First off, huge thanks for your patience - this PR has aged like a fine wine. 🍷
While this was quietly sitting here, we've made some changes to our codebase and introduced ruff as our new code formatting sheriff. Would you mind:

  • Running ruff check and ruff format locally to align with our new style guidelines and fix the errors in the build.
  • Adding some tests for your proposed functionality

Really appreciate your contribution and sorry again for the rather... extended response time! Let us know if you need any help getting things updated. 🚀

@katiam2 katiam2 added the Awaiting changes Needs changes from the author label Dec 1, 2024
@EricOuma
Copy link
Author

EricOuma commented Dec 2, 2024

Hello @katiam2
I'll work on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Awaiting changes Needs changes from the author bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

form error message does not hit the tab with the error
3 participants
@EricOuma @katiam2 @jamesgilmorelyst