Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jazzmin showing untranslated string while logging out #496

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

arneatec
Copy link
Contributor

Jazzmin is showing untranslated 'Thanks for spending some quality time with the Web site today.' message in Django 4.x.x when doing standard logout (http://127.0.0.1:8000/bg/admin/logout/). Note the BG(Bulgarian language) in the url, uses internationalized urls.

The root of the problem is that jazzmin is using an outdated 'logged_out.html'. In it, the 'Thanks for..' string has a capital W in the word 'Web'. Django upstream has fixed this to use lowercase w ('web') in the following commit :
django/django@7d909b2

As a result, jazzmin shows an untranslatable sting that is not present in either django or jazzmin .po files.

This pull request fixes the issue for the current Django release and future releases provided that the string does not mutate even further.

@arneatec
Copy link
Contributor Author

Please note that only the first commit (c372f5f) is meant to be merged, the following one is to deal with the Github actions failing in the local repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants