Jazzmin showing untranslated string while logging out #496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jazzmin is showing untranslated 'Thanks for spending some quality time with the Web site today.' message in Django 4.x.x when doing standard logout (http://127.0.0.1:8000/bg/admin/logout/). Note the BG(Bulgarian language) in the url, uses internationalized urls.
The root of the problem is that jazzmin is using an outdated 'logged_out.html'. In it, the 'Thanks for..' string has a capital W in the word 'Web'. Django upstream has fixed this to use lowercase w ('web') in the following commit :
django/django@7d909b2
As a result, jazzmin shows an untranslatable sting that is not present in either django or jazzmin .po files.
This pull request fixes the issue for the current Django release and future releases provided that the string does not mutate even further.