Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improvements to variable names and event handling logic #2412

Closed
wants to merge 11 commits into from

Conversation

intls
Copy link
Contributor

@intls intls commented Dec 2, 2024

Why is this change needed?

Describe why this issue should be fixed and link to any relevant design docs, issues or other relevant items.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR primarily focuses on correcting typos and improving code clarity across multiple files, particularly in function names and comments. It also includes minor adjustments to variable names for consistency.

Detailed summary

  • Renamed ConnectToMutliAddr to ConnectToMultiAddr in gossipProfile.ts.
  • Fixed solanaVerficationsEnabled to solanaVerificationsEnabled in hubble.ts, index.ts, and other files.
  • Corrected processRustCommitedTransaction to processRustCommittedTransaction in several files.
  • Updated comments for clarity in syncEngine.test.ts, index.ts, and gossipProfileWorker.ts.
  • Fixed spelling errors such as recievedMessages to receivedMessages in gossipTestNode.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: e458c42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 6:01am

@sds
Copy link
Member

sds commented Dec 7, 2024

Please resolve conflicts and open a new PR. Thank you.

@sds sds closed this Dec 7, 2024
@intls intls deleted the errors_branch branch December 9, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants