Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs fix #2409

Closed
wants to merge 2 commits into from
Closed

Bugs fix #2409

wants to merge 2 commits into from

Conversation

romashka-btc
Copy link

@romashka-btc romashka-btc commented Nov 26, 2024

What was done:

  1. Fixed the issue of logging unsanitized user input.
  2. Corrected the improper interpretation of curly braces {} as literals in the shell.

Why it matters:

  • Logging unsanitized input allowed attackers to forge log entries, leading to misinformation and making issue diagnostics harder. ( Potencial "spoofing" )
  • Improper use of curly braces could cause hidden bugs, complicating code maintenance.

How it was fixed:

  • Added sanitization of user input before logging.
  • Updated the handling of curly braces to prevent incorrect interpretation.

Result:

  • Improved log security and increased code reliability.

PR-Codex overview

This PR focuses on improving the hubble.sh script to wait for Grafana readiness and enhancing the event fetching logic in index.ts by using the URL object for safe URL construction and adding error handling.

Detailed summary

  • Added the wait_for_grafana function in scripts/hubble.sh to check Grafana readiness.
  • Modified the curl command syntax for better readability.
  • Refactored event fetching logic in packages/hub-web/examples/events/index.ts to use the URL object.
  • Added error handling and logging for the event fetching process.
  • Included a waiting message when no events are found.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 261761a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 3:13pm

@sds
Copy link
Member

sds commented Dec 7, 2024

This is example code and the changes proposed don't make sense. Closing.

@sds sds closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants