Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shuttle): Use statsd host from env #2399

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Nov 11, 2024

Why is this change needed?

Use statsd host from env for shuttle

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR focuses on updating the statsd configuration in the shuttle package to use the STATSD_HOST environment variable for the host address, enhancing flexibility and avoiding hardcoded values.

Detailed summary

  • Updated host in statsd configuration from a hardcoded IP ("127.0.0.1") to use process.env["STATSD_HOST"] with a fallback to "127.0.0.1".

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-bug A fix for a bug with the current system label Nov 11, 2024
Copy link

changeset-bot bot commented Nov 11, 2024

🦋 Changeset detected

Latest commit: 5b80d1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/shuttle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 10:52pm

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.15%. Comparing base (1880070) to head (5b80d1a).
Report is 422 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2399       +/-   ##
===========================================
- Coverage   74.05%   44.15%   -29.91%     
===========================================
  Files          99      146       +47     
  Lines        9425    26288    +16863     
  Branches     2097     9311     +7214     
===========================================
+ Hits         6980    11607     +4627     
- Misses       2327    12895    +10568     
- Partials      118     1786     +1668     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjayprabhu sanjayprabhu merged commit d34a86d into farcasterxyz:main Nov 11, 2024
9 of 10 checks passed
@sanjayprabhu sanjayprabhu deleted the fix_shuttle_statsd branch November 11, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant