Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR BUG] - js console reporting sequencer using deprecated call in PixiJS #206

Closed
galaara98 opened this issue Oct 7, 2023 · 2 comments

Comments

@galaara98
Copy link

Describe the bug
not functional breaking, but should probably be addressed so that it doesnt get in the way later

To Reproduce
Steps to reproduce the behavior:
while using a browser connected to a foundry server that is showing dev tools (console tab)
while sequencer is a loaded module in a world
LOGIN to world in foundry
Look for orange warning is jsconsole related to PixiJS, expand warning to see if it is referencing sequencer

In js console of browser:
PixiJS Deprecation Warning: Setting interactive is deprecated, use eventMode = 'none'/'passive'/'auto'/'static'/'dynamic' instead.Deprecated since v7.2.0
index.mjs:2 at SequencerInterfaceLayer._setup (https://foundry.nodebased.server/modules/sequencer/module.js:19671:45)

Expected behavior
no warning from PixiJS that .../modules/sequencer/.... is using deprecated functionality

NOTE: if it is useful, I reported the exact same issue to theripper93, for a module of theirs: light-switch (displayname lightswitch), the module code is patreon only, so I cant point you too it.

I believe that the related configuration just need to be changed to new verbiage, or some other very slight tweaking (theripper93 mentioned in a discord chat, before they dug into it at all, that it most likely just needed to be updated to 'auto' instead of 'interactive'), but I don't want to lead you on path I have no expertise in, just trying to give you as much information as I can.

Setup:

  • Foundry Version: [e.g. 11.313]
  • System Version: [e.g. PF2e 5.6.2]
  • Sequencer Version: [e.g. 3.1.4]
  • Browser & version [e.g. OPERA GX 102.0.4880.90, but because it is a warning from a 3rd party .js i think this will not matter]

Active modules:

  • Sequencer
  • socketlib
  • No other (if other mods are loaded and one of them has the SAME issue, i don't think PixiJS will warn again, so first mod to trigger the warning is the one you can see in js console)

Additional context
Again, NOT FUNCTION BREAKING... just giving you a heads up that a 3rd party thing your code is using is popping off a deprecation warning.

@orangepeelbeef
Copy link

dupe of #199

@galaara98
Copy link
Author

Closing in agreeance with orangepeelbeef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants